1147035 - DeveloperToolbar.jsm uses gBrowser.contentDocument and gBrowser.contentWindow, which doesn't exist in e10s browsers

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1144149 will add contentDocumentAsCPOW and contentWindowAsCPOW shortcuts to gBrowser.

When that happens, DeveloperToolbar.jsm should be updated to use that instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Make DeveloperToolbar.jsm use the gBrowser.contentDocumentAsCPOW shortcut. r=?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8585646 [details] [diff] [review]
Make DeveloperToolbar.jsm use the gBrowser.contentDocumentAsCPOW shortcut. r=?

Review of attachment 8585646 [details] [diff] [review]:
-----------------------------------------------------------------

Not even sure what this stuff does, I just know that in the remote browser case, gBrowser.contentDocument is very much null.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8585646 [details] [diff] [review]
Make DeveloperToolbar.jsm use the gBrowser.contentDocumentAsCPOW shortcut. r=?

Review of attachment 8585646 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

No problem - thanks for the fast review!

https://hg.mozilla.org/integration/fx-team/rev/1152f5ef0bc1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1152f5ef0bc1