Closed
Bug 1147178
Opened 9 years ago
Closed 4 years ago
Implement the correct behavior for Cache.put when the Response has a termination reason
Categories
(Core :: Storage: Cache API, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: perry)
Details
Attachments
(1 file)
Right now, nothing in our code even sets InternalResponse::mTerminationReason, so I assume the part of the spec where we're supposed to reject with a TypeError is not implemented. We first need to fix our fetch implementation to set it properly and then make Cache respect it.
|
||
Updated•9 years ago
|
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
|
||
Updated•4 years ago
|
Component: DOM: Core & HTML → Storage: Cache API
|
||
Comment 1•4 years ago
|
||
Anne, is this still missing/needed/wanted?
|
||
Comment 2•4 years ago
|
||
I think this bit of the specification got some refactoring as there's no termination reason there anymore. Not sure about our code though.
Flags: needinfo?(annevk) → needinfo?(perry)
|
Assignee | |
Comment 3•4 years ago
|
||
The termination reason value still exists but is neither initialized (to a non-empty string) nor used. Looks like it can be removed.
Flags: needinfo?(perry)
|
|
Assignee | |
Comment 4•4 years ago
|
||
The termination reason doesn't exist in the Fetch spec anymore. The member
variable isn't ever used either.
|
||
Updated•4 years ago
|
Assignee: nobody → perry
Status: NEW → ASSIGNED
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4abcb6bd41ec remove InternalResponse::mTerminationReason r=dom-workers-and-storage-reviewers,sg
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•