1147233 - Remove unused "overlay_share_retry" string

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It became unused in bug 1130203. Dangling references can be found in mobile/android/base/strings.xml and mobile/android/base/locales/en-us/android_strings.dtd.

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 1

[Darren Lyons]

Hi Michael. Never committed to an open source project before but would really like to get involved and this looks like a good place to start. Do we need to assign a bug to ourselves before starting on it? Or is it possible that there are multiple people working on the same thing at the same thing? Hoping this will be the first of many bugs I fix.

Comment 2

[Darren Lyons]

Attachment: Remove unused 'overlay_share_retry' string

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Darren - welcome aboard! :D

(In reply to Darren Lyons from comment #1)
> Do we need to assign a bug to ourselves before starting on it?

In general, it is a good idea to prevent duplicated effort. For future bugs, you can just message on the bug (before you even start writing patches!) that you're interested in working on the bug and you should be assigned.

> Or is it possible that there are multiple people working
> on the same thing at the same thing?

We do our best to avoid this.

> Hoping this will be the first of many bugs I fix.

Looking forward to it! :)

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c76a1257d67

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8593971 [details] [diff] [review]
Remove unused 'overlay_share_retry' string

Review of attachment 8593971 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

By the way, when you upload patches, you should flag a reviewer by clicking the review box, selecting a ?, and typing the email address (or ":ircNick") of your reviewer (if you've already uploaded the patch, you can get back to this screen via the "Details" button on the attachment list). I'll just go ahead and give you the plus for now, but remember for next time!

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

Thanks, Darren!

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 6

[Darren Lyons]

Hi Michael,

Thanks. I was looking for where to set the reviewer flag and didn't find it, I know now.

Comment 7

[Darren Lyons]

Looks like the tests failed on the try test server? I had a look at the test failures and they seem unrelated. What should I do next?

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Darren Lyons from comment #7)
> Looks like the tests failed on the try test server? I had a look at the test
> failures and they seem unrelated. What should I do next?

If you click on a test suite and look at the bar at the bottom of the page, you'll see bugs filed about intermittent failures that match your failures. In this case, it looks like all of the errors are related to intermittents, especially since your patch didn't touch this code. Feel free to add checkin-needed.

By the way, when you have a question, you can use the "Need more information from" field below the comment box - just type in an email or ":ircnick" (e.g. ":mcomella") or select a user from the dropdown. It provides the chosen user with a notification (rather than just an email) and your question is less likely to get lost! For example... (I don't actually need any info from you :P)

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

If you'd like some followup work, perhaps look at bug 1105271 (if you have a tablet) or bug 1121651?

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/90ed22ad517e

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/90ed22ad517e