[B2G][SMS][MMS] Map settings "mms.debugging.enabled" to preference and ensure SmsService / MmsService DEBUG flags reflect runtime preference changes.

RESOLVED FIXED in Firefox 40

Status

Firefox OS
RIL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: freesamael, Assigned: freesamael)

Tracking

unspecified
2.2 S11 (1may)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog, firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1. Map the preference "mms.debugging.enabled" to a corresponding setting so it can be added to Settings menu later.
2. Update MmsService / SmsService to reflect runtime setting / preference changes.
Assignee: nobody → sawang
Blocks: 709564, 744684
[Tracking Requested - why for this release]:
tracking-b2g: --- → backlog
Blocks: 1155543
Created attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference
Attachment #8593870 - Flags: review?(btseng)
Comment on attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference

Review of attachment 8593870 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/gonk/MmsService.js
@@ +1532,5 @@
> +    let debugPref = false;
> +    try {
> +      DEBUG = debugPref || Services.prefs.getBoolPref(kPrefMmsDebuggingEnabled);
> +    } catch (e) {}
> +  },

We already have default value set in line#19.
We can simplify this as followed, don't we?
    try {
      DEBUG = Services.prefs.getBoolPref(kPrefMmsDebuggingEnabled);
    } catch (e) {}
Comment on attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference

Review of attachment 8593870 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comment addressed.

Thanks!
Attachment #8593870 - Flags: review?(btseng) → review+
Created attachment 8597773 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference. r=btseng
Attachment #8597773 - Attachment description: Map settings "mms.debugging.enabled" to preference → Map settings "mms.debugging.enabled" to preference. r=btseng
Attachment #8597773 - Flags: review+
Attachment #8593870 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b2666b51ce73
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.