1147305 - [B2G][SMS][MMS] Map settings "mms.debugging.enabled" to preference and ensure SmsService / MmsService DEBUG flags reflect runtime preference changes.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Samael Wang [:freesamael] (away for now)]

1. Map the preference "mms.debugging.enabled" to a corresponding setting so it can be added to Settings menu later.
2. Update MmsService / SmsService to reflect runtime setting / preference changes.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:

Comment 2

[Samael Wang [:freesamael] (away for now)]

Attachment: Map settings "mms.debugging.enabled" to preference

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference

Review of attachment 8593870 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/gonk/MmsService.js
@@ +1532,5 @@
> +    let debugPref = false;
> +    try {
> +      DEBUG = debugPref || Services.prefs.getBoolPref(kPrefMmsDebuggingEnabled);
> +    } catch (e) {}
> +  },

We already have default value set in line#19.
We can simplify this as followed, don't we?
    try {
      DEBUG = Services.prefs.getBoolPref(kPrefMmsDebuggingEnabled);
    } catch (e) {}

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference

Review of attachment 8593870 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comment addressed.

Thanks!

Comment 5

[Samael Wang [:freesamael] (away for now)]

Attachment: Map settings "mms.debugging.enabled" to preference. r=btseng

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b2666b51ce73

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2666b51ce73