Open
Bug 1147538
Opened 9 years ago
Updated 2 years ago
PaintedLayers that only contain EventRegion display items are recreated each frame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
NEW
People
(Reporter: mstange, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: perf, regression)
Attachments
(1 file, 1 obsolete file)
6.31 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Event region display items don't go through AttemptToRecyclePaintedLayer. So if a PaintedLayer only contains event region display items and no other display items, we won't reuse a layer.
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8853840 [details] [diff] [review] bug1147538.patch Review of attachment 8853840 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/painting/FrameLayerBuilder.cpp @@ +4484,5 @@ > opaquePixels.AndWith(itemVisibleRect); > + } > + > + paintedLayerData->Accumulate(this, item, opaquePixels, > + itemVisibleRect, itemClip, layerState); Calling this for event region items might change the layer's visible region, which could cause us to create unnecessarily large layer buffers. If you implement IsUniform on nsDisplayEventRegions and make it return NS_RGBA(0,0,0,0), that should work around that problem.
Attachment #8853840 -
Flags: review?(mstange)
I think this addresses the problem in comment #2.
Attachment #8853840 -
Attachment is obsolete: true
Attachment #8856299 -
Flags: review?(mstange)
Reporter | ||
Updated•7 years ago
|
Attachment #8856299 -
Flags: review?(mstange) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f179621a517b Accumulate event region items into painted layers. (bug 1147538, r=mstange)
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/34c60d0619c063f1d31d3ad5d7032e4129f11f98 for OSX e10s reftest failures like https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/mozilla-inbound_yosemite_r7-debug_test-reftest-e10s-1-bm107-tests1-macosx-build357.txt.gz&only_show_unexpected=1
Flags: needinfo?(dvander)
Flags: needinfo?(dvander)
Comment 6•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: dvander → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•