1147713 - Various ReadingList tests are going to permafail when Gecko 39 merges to Aurora

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: xpcshell log

[Tracking Requested - why for this release]: Multiple permafails on Monday's uplift.

xpcshell
https://treeherder.mozilla.org/logviewer.html#?job_id=5924719&repo=try

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: mochitest-bc log

mochitest-bc
https://treeherder.mozilla.org/logviewer.html#?job_id=5924725&repo=try

Comment 2

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Drew, these look like a few .includes() still slipped through, but should be quite trivial to fix.  Can you have a look at this?

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 39.

Comment 4

[Drew Willcoxon :adw]

The reading list failures in comment 0 and 1 will be fixed by bug 1147113.  Comment 1 has other failures:

23:03:42 INFO - 523 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_mcb_redirect.js | uncaught exception - ReferenceError: ok is not defined at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug435325.js:60

I don't know what those are about but they don't seem related to reading list.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Different failure filed under a different bug ;)

Comment 6

[Drew Willcoxon :adw]

Oh no, this was actually fixed already by the last patch to land in bug 1131416:

http://hg.mozilla.org/mozilla-central/annotate/37d3dcbf23a9/browser/components/readinglist/ReadingList.jsm#l994

(It's true that bug 1147113 would have fixed it too.)

That patch landed on m-c yesterday.

There are no more array.includes() calls in readinglist: http://mxr.mozilla.org/mozilla-central/search?find=%2Fbrowser%2Fcomponents%2Freadinglist%2F&string=includes

So I'll close this bug.