Closed Bug 1147731 Opened 11 years ago Closed 10 years ago

Turn on/off screen only works in system app

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pyang, Assigned: pyang)

References

Details

Attachments

(1 file, 1 obsolete file)

[gaia] zapion:gaiatest_bug_1147731 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
martijn.martijn
: review+
jlorenzo
: review+
Details | Review
STR: - Switch to displayed app or any page other than system app. - Run GaiaDevice().turn_screen_on() EXPECT: - Device screen can be turn on/off successfully ACTUAL: - Javascript exception risen, ScreenManager is undefined
Attached file PR for gaia_test.py (obsolete) —
Waiting for treeherder.
Attachment #8583588 - Flags: feedback?(martijn.martijn)
Attachment #8583588 - Flags: feedback?(jlorenzo)
Attachment #8583588 - Attachment is obsolete: true
Attachment #8583588 - Flags: feedback?(martijn.martijn)
Attachment #8583588 - Flags: feedback?(jlorenzo)
Attachment #8583581 - Flags: review?(martijn.martijn)
Comment on attachment 8583581 [details] [review] [gaia] zapion:gaiatest_bug_1147731 > mozilla-b2g:master r+ assuming all tests pass, specifically the ones that use turn_screen_off, turn_screen_on and is_screen_enabled.
Attachment #8583581 - Flags: review?(martijn.martijn) → review+
Attachment #8583581 - Flags: review?(jlorenzo)
Hi Johan, can you help to review? thanks!
Comment on attachment 8583581 [details] [review] [gaia] zapion:gaiatest_bug_1147731 > mozilla-b2g:master Like you mentioned, we can factorize the 3 functions. It's not blocking the merge though. Apart from that, the last run tells the test passed!
Attachment #8583581 - Flags: review?(jlorenzo) → review+
I'll file another bug to track refactor for system app features. Please help to merge pr, thanks.
Blocks: 1148267
Sorry, I haven't seen your request. Let's ask autolander to merge the PR.
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reverted for Gaia UI test failures. Master: https://github.com/mozilla-b2g/gaia/commit/f37f43de98f51e2d040f5eb141b6d75b659d732f https://treeherder.mozilla.org/logviewer.html#?job_id=1770386&repo=b2g-inbound
Assignee: nobody → pyang
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded as we've disabled the test for now in bug 1156935: https://github.com/mozilla-b2g/gaia/commit/b988b34bd1a06ade1ce2cbf8b763ffc42460f465
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Depends on: 1156935
Depends on: 1150920
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: