1147744 - Green bar with YouTube on Mac

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Screen shot with green bar

Replaying the same video several times I got a green bar on the right hand side of the screen.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Asynchronous Pan/Zoom       none
Device ID                   0x6741
GPU Accelerated Windows     1/1 OpenGL (OMTC)
Vendor ID                   0x1002
WebGL Renderer              ATI Technologies Inc. -- AMD Radeon HD 6630M OpenGL Engine
windowLayerManagerRemote    true
AzureCanvasBackend          quartz
AzureContentBackend         quartz
AzureFallbackCanvasBackend  none
AzureSkiaAccelerated        0

Comment 2

[Jean-Yves Avenard [:jya]]

Vevo are MSE now? There weren't last time I played one of them. 

What OS?

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Jean-Yves Avenard [:jya] from comment #2)
> Vevo are MSE now? There weren't last time I played one of them. 
> 
> What OS?

YouTube (see URL). Mac OSX 10.7. Setting the video to 480 lines gives a resolution of 859x480 so we may need to crop the RHS of the output image or something. I can also reproduce it on my MacBook Pro with a GeForce GT 330M.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Round down display size

round to lowest nearest integer

Comment 5

[Ralph Giles (:rillian)]

Can we land this now that merge day has passed?

Comment 6

[Jean-Yves Avenard [:jya]]

Anthony said that didn't fix the problem for him.. I have received the mac mini which exhibited the problem.. just need to find the time to investigate now

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Properly calculate cropping value

The default chrome format is 4:2:0, not monochrome \!

Comment 9

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d540c29d5c2f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/801b4019fb00

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d540c29d5c2f
https://hg.mozilla.org/mozilla-central/rev/801b4019fb00

Comment 11

[Chris Peterson [:cpeterson]]

I verified that this fixed the video problem I reported in duplicate bug 1151291.

Jean-Yves: should we uplift this fix to Aurora 39 or Beta 38? AFAIK, we plan to ship MSE for YouTube on OS X in Firefox 38.

Comment 12

[Jean-Yves Avenard [:jya]]

Comment on attachment 8589003 [details] [diff] [review]
Part2. Properly calculate cropping value

Approval Request Comment
[Feature/regressing bug #]: 1147744
[User impact if declined]: Image displayed may shows invalid pixels
[Describe test coverage new/current, TreeHerder]: Minimal testing, ensuring that it didn't introduce obvious regressions and testing against values returned by WMF.
[Risks and why]: Low, this is more closely implementing the H264 specs and fixes a invalid default value
[String/UUID change made/needed]: None

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8589003 [details] [diff] [review]
Part2. Properly calculate cropping value

Approving for uplift to aurora; low-risk regression fix.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40a427f948c9
https://hg.mozilla.org/releases/mozilla-aurora/rev/21784d04ac24

Comment 15

[Jean-Yves Avenard [:jya]]

This code path wasn't activated on Mac (and still isn't by default) so not really a regression

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8589003 [details] [diff] [review]
Part2. Properly calculate cropping value

Taking it in case we decide to do something with MSE under Mac.
Should be in 38 beta 4.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f8ebd186863
https://hg.mozilla.org/releases/mozilla-beta/rev/c4a01c159cb6