need transition when switching between light-dark-sepia

VERIFIED FIXED in Firefox 38

Status

defect
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: madhava, Assigned: bwinton)

Tracking

(Blocks 1 bug)

34 Branch
Firefox 39
x86
macOS
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox38 verified, firefox39 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

4 years ago
Have a look at the fade-in transition on Fennec iOS.
Seems like a pretty quick thing to patch…
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Points: --- → 1
Attachment #8583963 - Flags: ui-review?(mmaslaney) → ui-review+
Comment on attachment 8583963 [details] [diff] [review]
bug1147889.diff

Requesting review now that the UI is how we want it.
Attachment #8583963 - Flags: review?(bmcbride)
Attachment #8583963 - Flags: review?(bmcbride) → review+
Keywords: checkin-needed
Carrying forward r=Unfocused and ui-r=mmaslaney.
Attachment #8583963 - Attachment is obsolete: true
Attachment #8584930 - Flags: ui-review+
Attachment #8584930 - Flags: review+
Flags: qe-verify+
QA Contact: andrei.vaida
https://hg.mozilla.org/mozilla-central/rev/f9ea7af9d7a9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Uplift request:

[User impact if declined]: There will be a more jarring transition when switching background colours.
[Describe test coverage new/current, TBPL]: Manual testing, and baking on mozilla-central for three days.
[Risks and why]: Low risk because its a two line change impacting only reader mode.
[String/UUID change made/needed]: none
Verified fixed on Nightly 40.0a1 (2015-04-02) and Aurora 39.0a2 (2015-04-02), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Comment on attachment 8584930 [details] [diff] [review]
The checkin-able version of the patch.

(I think bwinton meant to flip these flags)

Also, we have a similar transition on Fennec, but I didn't add it originally on desktop because we thought it was too jarring. Maybe we should port this improved version over to Fennec as well.
Attachment #8584930 - Flags: approval-mozilla-beta?
Attachment #8584930 - Flags: approval-mozilla-aurora?

Updated

4 years ago
Blocks: 1151004
Comment on attachment 8584930 [details] [diff] [review]
The checkin-able version of the patch.

aurora (39) already has the fix. Should be in 38 beta 2
Attachment #8584930 - Flags: approval-mozilla-beta?
Attachment #8584930 - Flags: approval-mozilla-beta+
Attachment #8584930 - Flags: approval-mozilla-aurora?
Attachment #8584930 - Flags: approval-mozilla-aurora-
Verified fixed on Beta 38.0b2-build1 (20150406174117) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.