Closed Bug 1147889 Opened 11 years ago Closed 11 years ago

need transition when switching between light-dark-sepia

Categories

(Firefox Graveyard :: Reading List, defect)

Product:
Firefox Graveyard
Component:
Reading List
Version:
34 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 verified, firefox39 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: madhava, Assigned: bwinton)

References

Details

Attachments

(1 file, 1 obsolete file)

The checkin-able version of the patch.
1.59 KB, patch
bwinton
: review+
bwinton
: ui-review+
Sylvestre
: approval-mozilla-aurora-
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Have a look at the fade-in transition on Fennec iOS.
Seems like a pretty quick thing to patch…
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Points: --- → 1
Attachment #8583963 - Flags: ui-review?(mmaslaney) → ui-review+
Comment on attachment 8583963 [details] [diff] [review] bug1147889.diff Requesting review now that the UI is how we want it.
Attachment #8583963 - Flags: review?(bmcbride)
Attachment #8583963 - Flags: review?(bmcbride) → review+
Keywords: checkin-needed
Carrying forward r=Unfocused and ui-r=mmaslaney.
Attachment #8583963 - Attachment is obsolete: true
Attachment #8584930 - Flags: ui-review+
Attachment #8584930 - Flags: review+
status-firefox38: --- → affected
status-firefox39: --- → affected
Flags: qe-verify+
QA Contact: andrei.vaida
https://hg.mozilla.org/mozilla-central/rev/f9ea7af9d7a9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox39: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Uplift request: [User impact if declined]: There will be a more jarring transition when switching background colours. [Describe test coverage new/current, TBPL]: Manual testing, and baking on mozilla-central for three days. [Risks and why]: Low risk because its a two line change impacting only reader mode. [String/UUID change made/needed]: none
Verified fixed on Nightly 40.0a1 (2015-04-02) and Aurora 39.0a2 (2015-04-02), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
Comment on attachment 8584930 [details] [diff] [review] The checkin-able version of the patch. (I think bwinton meant to flip these flags) Also, we have a similar transition on Fennec, but I didn't add it originally on desktop because we thought it was too jarring. Maybe we should port this improved version over to Fennec as well.
Attachment #8584930 - Flags: approval-mozilla-beta?
Attachment #8584930 - Flags: approval-mozilla-aurora?
Blocks: 1151004
Comment on attachment 8584930 [details] [diff] [review] The checkin-able version of the patch. aurora (39) already has the fix. Should be in 38 beta 2
Attachment #8584930 - Flags: approval-mozilla-beta?
Attachment #8584930 - Flags: approval-mozilla-beta+
Attachment #8584930 - Flags: approval-mozilla-aurora?
Attachment #8584930 - Flags: approval-mozilla-aurora-
Verified fixed on Beta 38.0b2-build1 (20150406174117) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
status-firefox38: fixed → verified
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: