1147942 - “An IndexedDB transaction that was not yet complete has been aborted due to page navigation”

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[talex5]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150321212544

Steps to reproduce:

1. Go to http://test.roscidus.com/static/idb.html
2. Open browser console with Ctrl-Shift-J
3. Refresh page a couple of times (Ctrl-R)


Actual results:

Console shows

"Transaction complete" idb.html:16:1
An IndexedDB transaction that was not yet complete has been aborted due to page navigation. idb.html:13:0
"Transaction complete" idb.html:16:1
An IndexedDB transaction that was not yet complete has been aborted due to page navigation. idb.html:13:0
"Transaction complete" idb.html:16:1


Expected results:

There should be no incomplete transactions (the page simply makes a single write when loaded).

I asked about this on stackoverflow.com and was told it might be a browser bug:

http://stackoverflow.com/questions/29242346/an-indexeddb-transaction-that-was-not-yet-complete-has-been-aborted-due-to-page

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Yeah, something is fishy here.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Tighten up warnings, v1

This cleans up the warning code a little. The big problem was that we were warning for all readwrite transactions, regardless of whether they had completed or not.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8625392 [details] [diff] [review]
Tighten up warnings, v1

Review of attachment 8625392 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBObjectStore.cpp
@@ +1434,5 @@
>  IDBObjectStore::Index(const nsAString& aName, ErrorResult &aRv)
>  {
>    AssertIsOnOwningThread();
>  
> +  if (mTransaction->IsCommittingOrDone() || mDeletedSpec) {

The |mDeletedSpec| piece here should have been included in a previous bug... But since I'm changing this line anyway...

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8625392 [details] [diff] [review]
Tighten up warnings, v1

Review of attachment 8625392 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good

::: dom/indexedDB/IDBTransaction.cpp
@@ +480,5 @@
>  IDBTransaction::SendAbort(nsresult aResultCode)
>  {
>    AssertIsOnOwningThread();
>    MOZ_ASSERT(NS_FAILED(aResultCode));
> +  MOZ_ASSERT(mReadyState == COMMITTING);

This should be |MOZ_ASSERT(IsCommittingOrDone());|

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/195067eb3141

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/195067eb3141