1147991 - Smooth share overlay entry animation

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sometimes it's kind of janky. Some thoughts on the cause:
  * We get the clients list in the background and then replace the list state with something else
    - (most likely) The list state gets updated while the dialog slides in, forcing a global layout
    - Background computation of getting the clients causes jank in the animation
  * We override the default animations of the Android system, and it stalls when switching Activities because of this

Note that this is not a problem when the device is rotated and the dialog slides in again (bug 1132729), hence why I think it's a layout issue.

Best solution is probably to set the list state BEFORE or AFTER layout. Perhaps we can have an additional animation to make the list appear after the first animation finishes?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Consider combining this effort with bug 1132730 by using the TransitionAwareCursorLoaderCallbacks.

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TransitionAwareCursorLoaderCallbacks.java

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.