Closed
Bug 1148197
Opened 9 years ago
Closed 9 years ago
Share overlay misaligned on small devices
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox38 verified, firefox39 verified)
VERIFIED
FIXED
Firefox 39
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(3 files, 1 obsolete file)
Fragmentation...!
Assignee | ||
Comment 1•9 years ago
|
||
/r/6193 - Bug 1148197 - Move share overlay margins to child to properly align. r=liuche Pull down this commit: hg pull review -r 711e8af15b1ca505aca699ea6f1ad437a6ef4ed5
Attachment #8584207 -
Flags: review?(liuche)
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8584207 [details] MozReview Request: bz://1148197/mcomella https://reviewboard.mozilla.org/r/6191/#review5189 Ship It! ::: mobile/android/base/resources/layout/overlay_share_dialog.xml (Diff revision 1) > <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" If this isn't used, remove it in a follow-up.
Attachment #8584207 -
Flags: review?(liuche) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/6191/#review5191 > If this isn't used, remove it in a follow-up. https://bugzilla.mozilla.org/show_bug.cgi?id=1148244
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8584207 [details] MozReview Request: bz://1148197/mcomella Approval Request Comment [Feature/regressing bug #]: bug 1130203 [User impact if declined]: Users on small screen devices will see a misaligned share overlay [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Low - we change the style so that the parent's margins go to the child. Worst case, same problem. [String/UUID change made/needed]: None
Attachment #8584207 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/521c3eb71374
Updated•9 years ago
|
status-firefox38:
--- → affected
status-firefox39:
--- → affected
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/521c3eb71374
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Updated•9 years ago
|
Attachment #8584207 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•9 years ago
|
||
Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella
This missed the uplift to Aurora. It'll need to go through the Beta approval process.
Attachment #8584207 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8584207 [details] MozReview Request: bz://1148197/mcomella Approval Request Comment 5
Attachment #8584207 -
Flags: approval-mozilla-beta?
Attachment #8584207 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Attachment #8584207 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8584207 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/4db575e80883
Comment 11•9 years ago
|
||
Verified fixed on Nightly 40.0a1 (2015-04-09) and Aurora (2015-04-09) on HTC Desire S (3.7" display) Still needs to be verified on Beta 38.0b4 before closing
Comment 12•9 years ago
|
||
Verified fixed on Beta 38.0b3 HTC Desire S (3.7" display)
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #8584207 -
Attachment is obsolete: true
Attachment #8619888 -
Flags: review+
Assignee | ||
Comment 14•9 years ago
|
||
Updated•6 years ago
|
Flags: qe-verify+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•