1148197 - Share overlay misaligned on small devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Fragmentation...!

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1148197/mcomella

/r/6193 - Bug 1148197 - Move share overlay margins to child to properly align. r=liuche

Pull down this commit:

hg pull review -r 711e8af15b1ca505aca699ea6f1ad437a6ef4ed5

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Post patch

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

https://reviewboard.mozilla.org/r/6191/#review5189

Ship It!

::: mobile/android/base/resources/layout/overlay_share_dialog.xml
(Diff revision 1)
>  <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

If this isn't used, remove it in a follow-up.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/6191/#review5191

> If this isn't used, remove it in a follow-up.

https://bugzilla.mozilla.org/show_bug.cgi?id=1148244

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

Approval Request Comment
[Feature/regressing bug #]: bug 1130203
[User impact if declined]:
  Users on small screen devices will see a misaligned share overlay

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  Low - we change the style so that the parent's margins go to the child. Worst case, same problem.

[String/UUID change made/needed]: None

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/521c3eb71374

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/521c3eb71374

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

This missed the uplift to Aurora. It'll need to go through the Beta approval process.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

Approval Request Comment 5

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4db575e80883

Comment 11

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 40.0a1 (2015-04-09) and Aurora (2015-04-09) on HTC Desire S (3.7" display)
Still needs to be verified on Beta 38.0b4 before closing

Comment 12

[Catalin Suciu [:csuciu]]

Verified fixed on Beta 38.0b3 HTC Desire S (3.7" display)

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1148197 - Move share overlay margins to child to properly align. r=liuche