Closed Bug 1148197 Opened 5 years ago Closed 5 years ago

Share overlay misaligned on small devices

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 39
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Attached image Screenshot
Fragmentation...!
/r/6193 - Bug 1148197 - Move share overlay margins to child to properly align. r=liuche

Pull down this commit:

hg pull review -r 711e8af15b1ca505aca699ea6f1ad437a6ef4ed5
Attachment #8584207 - Flags: review?(liuche)
Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

https://reviewboard.mozilla.org/r/6191/#review5189

Ship It!

::: mobile/android/base/resources/layout/overlay_share_dialog.xml
(Diff revision 1)
>  <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

If this isn't used, remove it in a follow-up.
Attachment #8584207 - Flags: review?(liuche) → review+
Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

Approval Request Comment
[Feature/regressing bug #]: bug 1130203
[User impact if declined]:
  Users on small screen devices will see a misaligned share overlay

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  Low - we change the style so that the parent's margins go to the child. Worst case, same problem.

[String/UUID change made/needed]: None
Attachment #8584207 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/521c3eb71374
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Attachment #8584207 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

This missed the uplift to Aurora. It'll need to go through the Beta approval process.
Attachment #8584207 - Flags: approval-mozilla-aurora+
Comment on attachment 8584207 [details]
MozReview Request: bz://1148197/mcomella

Approval Request Comment 5
Attachment #8584207 - Flags: approval-mozilla-beta?
Attachment #8584207 - Flags: approval-mozilla-aurora?
Attachment #8584207 - Flags: approval-mozilla-aurora?
Attachment #8584207 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Verified fixed on Nightly 40.0a1 (2015-04-09) and Aurora (2015-04-09) on HTC Desire S (3.7" display)
Still needs to be verified on Beta 38.0b4 before closing
Verified fixed on Beta 38.0b3 HTC Desire S (3.7" display)
Status: RESOLVED → VERIFIED
Attachment #8584207 - Attachment is obsolete: true
Attachment #8619888 - Flags: review+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.