Marionette's in_app restart has to send 'quit-application-requested' observer notification before an in_app restart

RESOLVED FIXED in Firefox 52

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: galgeek, Assigned: whimboo)

Tracking

(Blocks: 2 bugs, {ateam-marionette-server})

unspecified
mozilla52
ateam-marionette-server
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Firefox UI Tests' restart() method currently fails to store open tabs properly unless preceded by additional code like this:

        self.marionette.execute_script("""
          Components.utils.import("resource://gre/modules/Services.jsm");
          let cancelQuit = Components.classes["@mozilla.org/supports-PRBool;1"]
                                     .createInstance(Components.interfaces.nsISupportsPRBool);
          Services.obs.notifyObservers(cancelQuit, "quit-application-requested", null);
        """)

It would be good to add this to the restart() method, perhaps via a parameter, since this won't matter to many tests.

Chris Manchester first reported this here: https://bugzilla.mozilla.org/show_bug.cgi?id=1132701#c4
(Assignee)

Comment 1

3 years ago
That's what I told Chris when he was working on the in_app restart functionality of Marionette. See bug 1137388 comment 11. He told that this is not necessary. But it looks like it is. So this is a Marionette bug and nothing we have to do in our tests.
Component: Firefox UI Tests → Marionette
Depends on: 1137388
Product: Mozilla QA → Testing
QA Contact: hskupin
Summary: Add ability to store open tabs to restart() method → Marionette's in_app restart has to send 'quit-application-requested' observer notification before an in_app restart
(In reply to Henrik Skupin (:whimboo) [away 03/25 - 03/31] from comment #1)
> That's what I told Chris when he was working on the in_app restart
> functionality of Marionette. See bug 1137388 comment 11. He told that this
> is not necessary. But it looks like it is. So this is a Marionette bug and
> nothing we have to do in our tests.

Clearly the significance of that comment was lost. Fortunately we figured out the issue as soon as it came up and this code can easily be added in marionette or anywhere it's needed.
Keywords: ateam-marionette-server
(Assignee)

Updated

2 years ago
Blocks: 1141335
(Assignee)

Updated

2 years ago
Blocks: 1258982
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8794806 [details]
Bug 1148220 - Marionette's in_app restart has to send 'quit-application-requested' observer notification.

https://reviewboard.mozilla.org/r/81100/#review80254
Attachment #8794806 - Flags: review?(dburns) → review+
(Assignee)

Updated

a year ago
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

Comment 5

a year ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b99e97b8f228
Marionette's in_app restart has to send 'quit-application-requested' observer notification. r=automatedtester

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b99e97b8f228
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.