1148478 - Signed add-ons won't install

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

We signed an add-on in production and when we tried to install it we hit http://cl.ly/image/2g0L2K470g3O .  When installed off disk it worked fine, which indicates AMO is sending a hash in the install call and the hash isn't matching the add-on we're sending.

Maybe we're building the hash before signing or something?

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/492

Comment 2

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/d7949c711c706583bf0516ab977e6a6951fb7bae

Comment 3

[Valentina Virlics [:vvalentina], Ecosystem QA]

1. I've submitted an addon on AMO-dev (https://addons-dev.allizom.org/en-US/firefox/addon/testaddon1984/)
2. I've approved the submitted addon(according to my infos, after approving an addon, it is automatically signed)
3. I was able to install the new submitted-signed addon on AMO-dev FF38(Win 7). 
Please see screencast: http://screencast.com/t/b5h8OtiiJLNn

We have no rights for approving an addon in AMO-prod, so I could not verify there. 
If you guys can give us some STR to be tested on AMO-prod, we will. 
Thanks!

Comment 4

[Mathieu Agopian [:magopian]]

I think this needs to be QA'ed by krupa, I think she has the rights on prod (I don't)

Comment 5

[krupa raj[:krupa]]

I verified this bug on prod earlier but forgot to update the bug.