1148626 - [RTL][Dialer] Arabic characters are cut off at the bottom in call log

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Yeojin Chung [:YeojinC]]

Attachment: ArabicCutOff.png

Description:
Arabic characters are cut off at the bottom in the call log.

Repro Steps:
1) Update a Flame to 20150327010205.
2) Set the device language in Arabic under Settings > Language.
3) Open Dialer.
4) Call Voicemail, and hang up.
5) Go to Daier > Call log.
6) Observe the "voicemail" text in the call log.


Actual:
Arabic characters are cut off at the bottom.
(The two dots in "تي" are not shown.)

Expected:
Arabic characters are displayed completely. 

Notes:
This issue does NOT reproduce with Latin characters. The charaters like "g", "q", "y" are displayed properly.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150327010205 (KK, 319mb, full flash)
Gaia: 249b8c08c1d57961ef6c905f3498fa62b032bf24
Gecko: e046475a75cb
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 10/10
See attached: screenshot

Comment 1

[Yeojin Chung [:YeojinC]]

This issue also reproduces on Flame 2.2.

Result: On the call log, the two dots in "تي" (lower left side) are not shown.

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150327002500
Gaia: f9f62d7b69c9d46a28b5ca4f18993c90b5a2b26a
Gecko: 17079fdf6c6f
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Yeojin Chung [:YeojinC]]

Attachment: Callscreen.png

This screenshot shows how the string is shown in call screen. The red box indicates the area that is cut off in the call log.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

We should definitely not be having text cut off from the call log. Looking at the screenshot, seems like this is also happening on other text above (so not only the Voicemail string).
Nominating, and Triaging as P1. thanks

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: major issue on RTL

Comment 5

[Oleg Zasypkin [:azasypkin]]

As we agreed with :drs on IRC, I'll look into the issue

Comment 6

[Oleg Zasypkin [:azasypkin]]

Stealing...

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1148626-rtl-cut-arabic-chars > mozilla-b2g:master

Comment 8

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8586036 [details] [review]
[gaia] azasypkin:bug-1148626-rtl-cut-arabic-chars > mozilla-b2g:master

Hey Doug,

Here's a quick fix for "high" Arabic chars in contact name/carrier/phone-tag displayed in call log.

The idea is similar to what we'll probably have in SMS as well (bug 1140977 comment 1) - we're increasing line-height and the rest of changes is just to preserve original look & feel.

Please, let me know if you have better idea in mind.

Thanks!

Comment 9

[Doug Sherk (:drs) (inactive)]

Needinfo for uplift request.

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e8b15afbdae659c2a5ebec1f7e5b4b42bc0c91e4

Comment 11

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15428/

Comment 12

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8586036 [details] [review]
[gaia] azasypkin:bug-1148626-rtl-cut-arabic-chars > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): n/a, RTL requirement
[User impact] if declined: some Arabic characters (in contact name, carrier name, phone type tag) will be cut off in call log. 
[Testing completed]: yes, manual
[Risk to taking this patch] (and alternatives if risky): low, small targeted CSS-only fix
[String changes made]: n/a

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/43f863d3805fd7321379556b1f76904a85f419a1

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly 3.0 and 2.2 builds.

Actual Results:  Arabic text is not cut off on the bottom in call log entries.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150408010203
Gaia: 84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gecko: 078128c2600a
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150408002503
Gaia: ea735c21bfb0d78333213ff0376fce1eac89ead6
Gecko: 43041c78052b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 15

[Julien Wajsberg [:julienw]]

This bug could have been fixed by bug 1150449 too, so maybe you can try to revert it if you think this has other side-effects.