Closed Bug 1148645 Opened 5 years ago Closed 5 years ago

Long labels in buttons are truncated instead of wrapping

Categories

(Firefox OS Graveyard :: Gaia::Components, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S10 (17apr)
blocking-b2g 2.2+
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: tchevalier, Assigned: eragonj)

References

Details

Attachments

(3 files)

That's a recent regression on master, labels on buttons are now truncated while they were wrapping in multiple lines.

Tested on latest master build on Flame with French.

+ qawanted to check on 2.2, just to be sure it's not affected.
QA Contact: ktucker
Issue DOES reproduce on Flame 2.2 for both Browser Privacy and Devtools truncated strings.

"Effacer les cookies et les donnees..." and "Reinitialiser et activer les outils de..." are truncated.

Device: Flame 2.2(Full Flash)(KK)(319mb)
Build ID: 20150327002500
Gaia: f9f62d7b69c9d46a28b5ca4f18993c90b5a2b26a
Gecko: 17079fdf6c6f
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage+]
Keywords: qawanted, regression
Argh, thanks Kevin!

Nominating for 2.2 then, a lot of UI pieces are affected, and in most of the cases, the user can't/will have hard time to understand what the button does.

Also, I think it should be quite easy to fix.
blocking-b2g: --- → 2.2?
blocking-b2g: 2.2? → 2.2+
ni Arthur for comment.
Flags: needinfo?(arthur.chen)
It is unlikely to have multi-row buttons. Possible options would be reducing the font size or replacing the string with a shorter one. 

Stephany, is there any policy handling this kind of issues?
Flags: needinfo?(arthur.chen) → needinfo?(swilkes)
Hi Arthur,

This is a regression, buttons _were_ multi-row a few days ago, I think we could just back out the patch that caused this regression.
We can't change strings on 2.2 anymore.
Flags: needinfo?(swilkes)
The bug was regressed by another 2.2 blocker bug 1145835 so I'm afraid that we can't simply revert it.

EJ, it seems there are conflicts on the loading sequence between these two bugs. Any idea?
Flags: needinfo?(ejchen)
Comment on attachment 8590609 [details] [review]
[gaia] EragonJ:bug-1148645 > mozilla-b2g:master

Arthur, I think what we did in previous 2.2 patch is right and no need to backout. With that patch, buttons and some shared styles are loaded at first before lists.css and this is definitely right !

For me, I think the main problem is that we force to make all "ul li > *" "text-overflow: ellipsis;" and this would definitely influence multi-line buttons. 

So for this 2.2 bug, as a quickfix, I think it's acceptable to override "ul li button" (Yes, we did have this rule, so what I do here is add one more attribute).

Because styles in Settings App is getting in a state of chaos, I think we can try to survey what we can do to make it look better.

Any idea would be appreciated !
Flags: needinfo?(ejchen)
Attachment #8590609 - Flags: review?(arthur.chen)
Assignee: nobody → ejchen
Comment on attachment 8590609 [details] [review]
[gaia] EragonJ:bug-1148645 > mozilla-b2g:master

I agree that for this time being overriding makes a lot sense. r=me, thanks!
Attachment #8590609 - Flags: review?(arthur.chen) → review+
Duplicate of this bug: 1153115
Thanks Arthur, this patch was merged into Gaia/master :  https://github.com/mozilla-b2g/gaia/commit/3f6db9c25557e73f831e749a0c5621c685330507
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8590609 [details] [review]
[gaia] EragonJ:bug-1148645 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1145835
[User impact] if declined: some buttons with multi-lines translations would be truncated.
[Testing completed]: yes, with manual tests.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no
Attachment #8590609 - Flags: approval-gaia-v2.2?
Attachment #8590609 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
This issue is verified fixed on the latest Nightly 3.0 and 2.2 builds.

Actual Results: The text now wraps instead of truncating.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150416010206
Gaia: 629097847567e51095a454e7e63186a6e2ac0307
Gecko: a35163f83d22
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150416002504
Gaia: 8e24d8b7f5e7c74c3004b22710dda0dac3e04ead
Gecko: 41388836b5c6
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.