1148651 - [STK] No Terminal Response received for [SETUP EVENT LIST: Browser Termination] proactive command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Anshul]

STR:

- Run USAT GCF 27.22.7.9.1.1
- Card sends SET UP EVENT LIST: Browser Termination proactive command.

Expected: Terminal response for the set up event list
Observed: No terminal response being sent

Comment 1

[Anshul]

This seems like a regression from bug 1088611 where the code to send terminal response is explicitly removed.

Comment 2

[howie [:howie]]

Hi Wesley, are you in charge of the STK and triage this? Thanks.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Sean,
Can you look into this? (comment 1)

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Attachment: Trial Patch for v2.2

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8586579 [details]
Trial Patch for v2.2

Hi Anshul,

Could you try the patch?
I add the TR back.

Thank you.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Very likely this will be a blocker, but would like to hear from devs first.
We're very close to FC date (April6th).

Comment 7

[Anshul]

(In reply to Sean Lee [:seanlee] from comment #4)
> Created attachment 8586579 [details]
> Trial Patch for v2.2

Sean, would you know why this TR was removed in bug 1088611. I don't have access to the bug so don't know the history.

Comment 8

[Sean Lee [:seanlee][:weilonge]]

(In reply to Anshul from comment #7)
> Sean, would you know why this TR was removed in bug 1088611. I don't have
> access to the bug so don't know the history.

This is caused by another device's modem chip design.
The modem chip will send the TR for SET_UP_EVENT proactive command.

Comment 9

[Sean Lee [:seanlee][:weilonge]]

This is a mistake that the TR for SET_UP_EVENT proactive command is removed.
So I think this should be added back.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/v2.2/Bug1148651 > mozilla-b2g:v2.2

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Attachment: PR for v2.2

Hi Fernando,

Comment 12

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8588402 [details] [review]
PR for v2.2

Hi Fernando,

Could you help to review my PR?
Thank you very much.

Comment 13

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8588402 [details] [review]
PR for v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1088611
[User impact] if declined:
We won't pass STK test.
The current design is for a specific MODEM chip, not a generic one.
see comment 8

[Testing completed]:
Report has been accepted this changes.

[Risk to taking this patch] (and alternatives if risky):
Only sending a TR for SET_UP_EVENT. Very minor risky.

[String changes made]:
None

Comment 14

[Anshul]

Bhavna, could you please approve the uplift?

Comment 15

[Sean Lee [:seanlee][:weilonge]]

landed on v2.2: https://github.com/mozilla-b2g/gaia/commit/9a7cc87d2cc4e84f9e698b8d36f63af5e75b7cc5
gaia-try: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=56f3e348d5b807d02555b516ca565a4e095f93f1

Comment 16

[(PTO June 19-July 7) Ryan VanderMeulen]

Was v3.0 unaffected here?

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/master/Bug1148651 > mozilla-b2g:master

Comment 18

[Sean Lee [:seanlee][:weilonge]]

Attachment: PR for master

Hi Ryan, This is by modem chip design to send TR or not, so my opinion is adding the code to send TR. If there is any design changed for specific chip, we can customize it at device branch. Thank you.

Comment 19

[(PTO June 19-July 7) Ryan VanderMeulen]

Master: https://github.com/mozilla-b2g/gaia/commit/a0d4c222c1f1a8d2954539dac1537a1166aab320