1148663 - Allocations flame chart has incorrect x-axis

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The x-axis is currently time -- it should instead be number of allocations (and after bug 1068988, byte size) so that heavier allocators are wider.
I suspect that we might also be graphing width based on the allocations log timestamp rather than number of allocations. This is incorrect. The timestamp should only be used for filtering the set of data graphed when a subregion of a profile is selected.

Additionally, we should be sorting and aggregating the allocations as well, not displaying them in order. (Flame graph vs chart? I forget which is which...)

---------------------------------------------------------------------------

Here is an example: if the (chronologically ordered) allocations log yields

  [
    A->B->C,
    D->E,
    A->B->C,
    A->B->F->G->H,
    D->E,
    D->E,
  ]

we should end up with a flame graph like:

  AAADDD
  BBBEEE
  CCF
    G
    H

http://www.brendangregg.com/FlameGraphs/memoryflamegraphs.html has some general info, particularly section 1.

Comment 1

[Victor Porof [:vporof][:vp]]

Not doing allocations stuff for v2.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Not doing flames for the allocations data anymore.