1148670 - Correct MenuItemActionView.onLayout calculation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We shouldn't use padding - it should be

if (width < widthForViewInParent

where
  width = right - left;
  parentMeasuredSize = parentMeasuredWidth - parentPadding

Basically, we're checking to see if there is another child View next to us or if we take up the whole container width.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1148670/mcomella

/r/6241 - Bug 1148670 - Correct onLayout calculation in MenuItemActionView. r=mhaigh

Pull down this commit:

hg pull review -r b1187135037bee81ceb99e12a28cb983eb5626e9

Comment 2

[Martyn Haigh (:mhaigh)]

Comment on attachment 8584907 [details]
MozReview Request: bz://1148670/mcomella

https://reviewboard.mozilla.org/r/6239/#review5393

Ship It!

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/870fb46ef3ba

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/870fb46ef3ba

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1148670 - Correct onLayout calculation in MenuItemActionView. r=mhaigh