React to Backoff and Retry-After headers from Reading List storage servers

RESOLVED FIXED in Firefox 40

Status

Firefox Graveyard
Reading List
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 40
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Desktop version of bug 1140812 - our Sync client doesn't react to any backoff or retry headers.  In theory the scheduler is all set to honor them (is is listening for observer notifications), so we just need the Sync engine to send them.

Not clear what the priority is - hopefully the impact of *not* doing so isn't going to be user visible, but I'm sure the services team would like it and it may help improve the overall reliability.
Flags: qe-verify?
Flags: firefox-backlog+
P1 - sounds like we're going to want this as an important safety mechanism to deal with the possibility of an overloaded service.
Priority: -- → P1

Updated

3 years ago
Blocks: 1132074
Mark/Drew, can one of you take this?
Flags: needinfo?(mhammond)
Flags: needinfo?(adw)
(Assignee)

Comment 3

3 years ago
Created attachment 8591493 [details] [diff] [review]
0011-Bug-1148701-React-to-Backoff-and-Retry-After-headers.patch

Simple patch that has ServerClient send observer notifications upon the documented headers. Note that the scheduler already has support (and tests) for this notification.
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Flags: needinfo?(mhammond)
Flags: needinfo?(adw)
Attachment #8591493 - Flags: review?(adw)

Updated

3 years ago
Iteration: --- → 40.1 - 13 Apr

Updated

3 years ago
Attachment #8591493 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/e1d140a56d53
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
(Assignee)

Comment 6

3 years ago
Comment on attachment 8591493 [details] [diff] [review]
0011-Bug-1148701-React-to-Backoff-and-Retry-After-headers.patch

Approval Request Comment
[Feature/regressing bug #]: readinglist
[User impact if declined]: Fx might overload servers causing everyone to have a bad time
[Describe test coverage new/current, TreeHerder]: New test
[Risks and why]: Very low risk - limited to schedule of automatic reading list syncs.
[String/UUID change made/needed]: None
Attachment #8591493 - Flags: approval-mozilla-beta?
Attachment #8591493 - Flags: approval-mozilla-aurora?
status-firefox38: --- → affected
status-firefox39: --- → affected
Comment on attachment 8591493 [details] [diff] [review]
0011-Bug-1148701-React-to-Backoff-and-Retry-After-headers.patch

We don't want to DOS ourself. Taking it
Should be in 38 beta 5.
Attachment #8591493 - Flags: approval-mozilla-beta?
Attachment #8591493 - Flags: approval-mozilla-beta+
Attachment #8591493 - Flags: approval-mozilla-aurora?
Attachment #8591493 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/1566bebe56be
status-firefox39: affected → fixed
Flags: in-testsuite+
Setting qe-verify- since this fix seems to be already covered by automated tests.
Flags: qe-verify? → qe-verify-
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.