scheduler retries too aggressively on error

RESOLVED FIXED

Status

Firefox Graveyard
Reading List
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

(Blocks: 1 bug)

unspecified
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8584995 [details] [diff] [review]
0004-Bug-XXXXXXX-reading-list-scheduler-gets-a-back-off-s.patch

Currently the scheduler will retry a sync every 2 minutes until it sees success. This is too aggressive - if the server is overloaded or down this will cause every running profile to attack it :)  If the error is on the client side the user may notice increased network traffic and a performance hit. Later we should differentiate different types of error but until then we should be sensible.

This patch doubles the timeout on error with a max of the "normal" schedule - ie, first error will cause a 2 minute retry, then 4, 8, 16, 32 up to 7200 (default 2 hour schedule). Sequence restarts on next successful sync.  Note also we try and sync after any local RL item change regardless of the current schedule.

This is a fairly simple patch with tests. I think we should take it on 38 - in a worst-case scenario we could effectively DDOS our own service!
Attachment #8584995 - Flags: review?(adw)
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
(In reply to Mark Hammond [:markh] from comment #0)
> This patch doubles the timeout on error with a max of the "normal" schedule
> - ie, first error will cause a 2 minute retry, then 4, 8, 16, 32 up to 7200
> (default 2 hour schedule).

Doh - mixed up my units - 7200 is seconds - max is 2 hours, 120 minutes.
Attachment #8584995 - Flags: review?(adw) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/0c64436fdc79
https://hg.mozilla.org/integration/fx-team/rev/b34ca540cf73
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
status-firefox38: affected → fixed

Updated

3 years ago
Iteration: --- → 39.3 - 30 Mar

Updated

3 years ago
Blocks: 1132074
(Assignee)

Comment 3

3 years ago
Landed on central as https://hg.mozilla.org/mozilla-central/rev/b34ca540cf73
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: affected → fixed
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.