I have a WIP for this here: https://github.com/wesj/firefox-ios-1/tree/landscapeToolbar
Comment on attachment 8587069 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/295 Approach is OK, but I think this could use a fair amount of cleanup first. Also, let's be careful to avoid regressing the toolbar behavior on about:home.
Attachment #8587069 - Flags: review?(bnicholson) → feedback+
I've been playing lately and noticed that snackbar's don't show on about:home. We need to redo that approach. Its too fragile. I'll file a bug for it.
Comment on attachment 8587069 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/295 I don't have much to add on top of brian's review. Just one thing: This introduced a regression with the share popover: on iPad, tapping the share button greys out the screen but does not actually show the popover. Can that be fixed as part of this PR? It is probably just a matter of specifying the correct source view/rect.
Attachment #8587069 - Flags: review?(sarentz) → review+
I'm taking my r+ and running!
Had to land a follow up: https://github.com/mozilla/firefox-ios/pull/314
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.