Closed Bug 1148862 Opened 5 years ago Closed 5 years ago

Update pref to the new v3 endpoint

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox38 --- fixed
firefox39 --- verified
firefox40 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Whiteboard: .002)

Attachments

(2 files, 1 obsolete file)

Firefox supports the new v3 api and format, but it's still fetching from v2.
Depends on: 1149680
Attached patch v1 (obsolete) — Splinter Review
Preparing for future landing. We don't want to land this quite yet on nightly/aurora as we're still testing with the temporary data uri from bug 1148938.
Assignee: nobody → edilee
Attachment #8586619 - Flags: review?(adw)
Points: --- → 1
Comment on attachment 8586619 [details] [diff] [review]
v1

Wow. Don't wrie patches at 1am.

oyiptong, do ew want to hit v2 for the pings or might as well update the ping pref to v3 as well?
Attachment #8586619 - Attachment is obsolete: true
Flags: needinfo?(oyiptong)
Attachment #8586619 - Flags: review?(adw)
Let's update the url to v3. the implementation is probably going to be the same, but it might make for easier deprecation later
Flags: needinfo?(oyiptong)
Attached patch v2Splinter Review
Attachment #8586845 - Flags: review?(adw)
Attachment #8586845 - Flags: review?(adw) → review+
To be clear on why this hasn't landed on Nightly 40 or Aurora 39 yet..

This patch changes both the fetch and ping endpoint. Tiles are effectively turned off for Nightly and Aurora users because they're expecting v3 data format but are hitting the v2 endpoint. For en-US users that see tiles from bug 1148938's data uri, they'll hit the v2 ping endpoint, and we're able to see impressions and clicks from Nightly and Aurora users that get the unicorn tile.
Blocks: 1155443
No longer blocks: 1155443
https://hg.mozilla.org/mozilla-central/rev/116e87c05513
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Blocks: 1161412
Attached patch for auroraSplinter Review
Comment on attachment 8586845 [details] [diff] [review]
v2

[Triage Comment]  Approving for uplift from the request in bug 1161412 since this is part of the tiles feature we're putting into 39.
Attachment #8586845 - Flags: approval-mozilla-aurora+
Our comments crossed. Ed, now looking at these two patches they seem significantly different. I would like to make sure we are clear on this before uplift.
Comment on attachment 8586845 [details] [diff] [review]
v2

Best to hold off on this until Ed and I can straighten out what is intended.
Attachment #8586845 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora-
Comment on attachment 8602800 [details] [diff] [review]
for aurora

The aurora patch has removal of temporary code that didn't land on beta but did land on aurora.
Attachment #8602800 - Flags: review?(adw)
Comment on attachment 8602800 [details] [diff] [review]
for aurora

Approved for uplift to aurora as requested in bug 1161412.
Attachment #8602800 - Flags: approval-mozilla-aurora+
Blocks: 1140185
No longer blocks: 1161412
Iteration: --- → 40.3 - 11 May
Attachment #8602800 - Flags: review?(adw)
The pref was successfuly updated to fetch from the v3 endpoint
- browser.newtabpage.directory.source is set to https://tiles.services.mozilla.com/v3/links/fetch/%LOCALE%/%CHANNEL% by default.

Tested with:
- latest Nightly, build ID: 20150520030205
- latest Aurora, build ID: 20150520004004
- Firefox 39 beta 1, build ID: 20150520170903.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
You need to log in before you can comment on or make changes to this bug.