1148910 - Update reader view settings UI to latest UX specification

Status: RESOLVED FIXED

(Firefox for iOS :: Reader View, defect)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/287

This updates the Reader View Settings to the latest specification as documented in bug 1126486.

Couple of notes:

* This first iteration uses a standard UIPopover. So it does have an upward arrow and a blurred background. I had to timebox this but I can investigate if we can implement our own popover and make it look more like the specification.
* Pretty much all colors, constants, paddings and offsets are in the `ReaderModeStyleViewControllerUX` struct which can be modified to tweak things. Let me know if anything is missing there.
* I'll do a pass later on all the `*UX` structs that we have to move shared colors/fonts/etc to the `AppConstants` that are about to land.
* The brightness slider is hooked up to the system brightness settings. I am following iBooks here where this slider is changing the system brightness settings.
* The spec for the brightness slider has a smaller knob. It looks like iOS comes with just the default knob size. I tried a few things to scale that system knob image down but I don't think it is possible. So if we really want to change it we will need some custom images. (I don't know if we should. The knob size if obviously the way it is because it is a good tap area for your finger)
* I was not sure what the disabled button color exactly should be. The spec says '44% of 0x333333' but I think we need to translate that to a proper color code. Right now i just set it to the system's `lightGreyColor`.
* The row height is currently 50px as per spec. But I think it should be 44px instead to be in line with other UI elements like table views. Also gives a little more space on small devices.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8585174 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/287

Some thoughts in the PR, but nothing big. Nice!

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Merged with an additional patch to localize all the strings in the dialog. I did not things 'Serif' and 'Sans-serif' would be localized, but they are.