1148923 - [ja] Subdialog default width of in-content preferences is too narrow in ja locale

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Alice0775 White]

Attachment: screenshot comparison between en-US and ja

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Steps To Reproduce:
1. Tools > Options > Content > [Advanced...]
   ツール > オプション > コンテンツ > [詳細設定]
   --- observe width of the subdialog and font select box

2. Click a font select box
   --- observe width of the dropdown and option labels

Actual Results:
Subdialog default width and the font select box is too narrow in ja build

Expected Results:
These width should be wider as much as in en-US

Comment 1

[Francesco Lodolo [:flod]]

IIRC localizers don't have any way to set that width. If I'm right this bug should be in Firefox -> Preferences, since there's nothing localizers can't do to fix it.

Comment 2

[:Gijs (he/him)]

Seems like we should set a min-width on the font dropdown. AFAICT the reason this works on en-US is that the text lower down in the dialog is forcing a wider dialog.

Comment 3

[:Gijs (he/him)]

(we could add a width entity, but that doesn't port to 38)

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Until we find a solution that we can uplift (as well as understand the root cause of this issue), can you try adding some non-breaking spaces to your locale files to give more width to the dialog? You could add them to the &languages.customize.Fallback2.grouplabel; and until you get a width that is desired.

Flod, could that work for JA? If so, do you know who to forward this to on the ja-locale side?

Comment 5

[Francesco Lodolo [:flod]]

Abe, can you take a look this bug?

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 38+.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Any update here?

Comment 8

[ABE Hiroki (:hATrayflood)]

Attachment: Bug1148923_firefox-38.0b3.png

Comment 9

[ABE Hiroki (:hATrayflood)]

Attachment: Bug1148923_firefox-39.0a2.png

Comment 10

[ABE Hiroki (:hATrayflood)]

I tried to reproduce this probrem by following binaries. but not reproduced.

ftp://ftp.mozilla.org/pub/firefox/nightly/38.0b3-candidates/build1/win32/ja/firefox-38.0b3.zip
ftp://ftp.mozilla.org/pub/firefox/nightly/2015-04-11-00-40-12-mozilla-aurora-l10n/firefox-39.0a2.ja.win32.zip

Comment 11

[Alice0775 White]

Attachment: Reproduced on 38.0b3

Still reproduced.

Comment 12

[Alice0775 White]

Attachment: Firefox37.png

No problem on Firefox37

Comment 13

[Francesco Lodolo [:flod]]

I wonder if the browser's window size matters. Also Alice's image uses Windows Classic theme, Abe's doesn't.

Comment 14

[ABE Hiroki (:hATrayflood)]

Attachment: Bug1148923_firefox-38.0b3_classic.png

Comment 15

[ABE Hiroki (:hATrayflood)]

Attachment: Bug1148923_firefox-39.0a2_classic.png

Comment 16

[ABE Hiroki (:hATrayflood)]

not reproduced when classic theme.
any conditions?

Comment 17

[Alice0775 White]

Please compare with width of other language and normal dialog version(prior to 37).
Font subdialog on Ja locale is much narrower than the others.

Comment 18

[ABE Hiroki (:hATrayflood)]

Attachment: Bug1148923_firefox-39.0a2.en-US.png

Comment 19

[ABE Hiroki (:hATrayflood)]

indeed, ja locale is narrower than en-us.
but, does not look much narrow for me.

any concrete conditions?

Comment 20

[Alice0775 White]

classic, system font MS UI Gothic, size 11.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

As preferences in-tab is a new feature (from the Release POV), it would be nice if this bug could be fixed for 38.

Comment 22

[:Gijs (he/him)]

Attachment: Min-width the font selectors

Arguably this is a pretty font+language-specific issue, but this fixes things to an acceptable degree for me (this is a patch against beta which I suspect will be easy to run on m-c as well). Tested against beta with the japanese language pack. Obviously if you have very long font names, 30ch is still not going to be enough, but it should be OK for most disambiguation.

(r?mconley because jaws isn't accepting reviews)

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8592838 [details] [diff] [review]
Min-width the font selectors

Review of attachment 8592838 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, this is a low-risk fix that we can uplift to beta.

Comment 24

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a6b4ae672ec9

Comment 25

[:Gijs (he/him)]

Comment on attachment 8592838 [details] [diff] [review]
Min-width the font selectors

Approval Request Comment
[Feature/regressing bug #]: in-content prefs
[User impact if declined]: japanese locale with some fonts has a too-narrow fonts dialog
[Describe test coverage new/current, TreeHerder]: nope :-(
[Risks and why]: very low, CSS change to fix the width of the fonts dropdowns
[String/UUID change made/needed]: nope

Comment 26

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592838 [details] [diff] [review]
Min-width the font selectors

Not waiting for the patch to be in m-c to make sure it is in 38 beta 5.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8eab810238ea

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/45a5eaa7813b

Comment 29

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6b4ae672ec9

Comment 30

[Alice0775 White]

I verified that this was fixed on 38.0b5.
https://hg.mozilla.org/releases/mozilla-beta/rev/90271e6d8250
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150416143048