1149182 - Decide what to do with invalid logs

Status: RESOLVED DUPLICATE of bug 1057341

(Tree Management :: Treeherder, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bug 1149168 is about failure logs for Taskcluster jobs not listing any details about the job. Ed mentioned that this is because the pseudo-buildbot log that Taskcluster creates to submit to Treeherder isn't formatted correctly.

The short term fix is for Taskcluster to fix their log submission, but longer term, Treeherder should either:
a) reject invalidly formatted logs completely (with that rejection getting noted somewhere?) or
b) make it clearer in the log view that the submitted log was not formatted correctly, so people know that there's missing information (and why).

Comment 1

[Ed Morley [:emorley]]

As much as I'd like to reject invalid logs right now, if we did that all (/most) of the TC jobs would fail log parsing, so we'd need to wait for bug 1147958 to be fixed first.

If that bugs drags out, we could short term make the UI display a more helpful message, by making changes here:
https://github.com/mozilla/treeherder-ui/blob/4e553cb07e22689005594b2a0e8a87eee14b80a0/webapp/app/js/controllers/logviewer.js#L161
https://github.com/mozilla/treeherder-ui/blob/4e553cb07e22689005594b2a0e8a87eee14b80a0/webapp/app/logviewer.html#L18

Though ideally medium-long term we should stop this antiquated process of scraping the header from the log file and using that for job metadata (I was against doing this from the start; I remember a fairly heated debate at one of the early treeherder work weeks on this topic) by fixing bug 1057341.

Comment 2

[Ed Morley [:emorley]]

Let's not bother with multiple short-term workarounds; let's just fix bug 1057341. It probably won't take much longer.