1149221 - Disabled simulator still appear in WebIDE runtime list

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

After bug 1090949 (I think), disabling a simulator from the Add-on Manager page leaves it in the WebIDE runtime list forever.  Effectively, disabling has no effect.

I believe this is because WebIDE now searches out simulators by regex, effectively ignoring the add-on manager's info, since it now only needs file locations on disk and does not care about code the add-on would have run.

STR:

1. Open WebIDE
2. Look at runtime list
3. Open about:addons
4. Disable some simulator add-on
5. It will still be displayed in the runtime list

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Jan, I marked this as a regression mostly for tracking purposes.  I could imagine an argument that we don't care about this and decide to do nothing.  However, if it's easy to fix, we may want to do, as it's a little surprising.

Assigning and setting ni? since you'll be out a few days.

Comment 2

[Jan Keromnes [:janx]]

Nice catch. Like for bug 1149214, this happens because the list is currently generated directly from what `AddonManager.getAllAddons()` returns, including disabled addons.

This will be fixed when bug 1090949's last patches get merged, because they improve the way this list is updated.

Comment 3

[Jan Keromnes [:janx]]

Does this problem still occur?

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jan Keromnes [:janx] from comment #3)
> Does this problem still occur?

No, it seems to be fixed now, thanks!