1149226 - Reading List sync check box is deselected (off) after Nightly update

Status: VERIFIED FIXED

(Android Background Services Graveyard :: Reading List Sync, defect)

Comment 1

[Edwin Wong [:edwong]]

STR:
1. add items to RL (not synced from an old build of Nightly  Mar 28 or earlier)
2. upgrade Nightly to latest Mar 30 or later)
3. go into Settings > Sync
4. look at sync data types

actual: Reading List checkbox is unchecked (sync off).

expected: it should be checked (sync on)

Comment 2

[Nick Alexander :nalexander [he/him]]

Confirmed locally.  I will get on this.

Comment 3

[Richard Newman [:rnewman]]

Nick: this is the last blocker to turning RL sync on in Aurora and Beta.

Comment 4

[Nick Alexander :nalexander [he/him]]

For QA: (From the commit message.)
    
    The desired behaviour is: Reading List is syncing automatically if
    Firefox Sync is syncing automatically.
    
    Test plan: remove all Firefox Accounts.
    
    1) Install old version.  Add a Firefox Account.  Ensure that Firefox
    Sync is enabled.  Upgrade to new version.  Verify that Reading List is
    enabled.
    
    2) Install old version.  Add a Firefox Account.  Manually disable
    Firefox Sync by unchecking the checkbox in Android Settings >
    Accounts.  (This can not be done from the Firefox Account settings
    activity; unchecking the 4 boxes there is not the same.)  Upgrade to new
    version.  Verify that Reading List is disabled.
    
    3) Install new version.  Add a new Firefox Account.  Verify that Reading
    List is enabled.
    
    (There are automated tests for these scenarios.)

Comment 5

[Richard Newman [:rnewman]]

Attachment: Pull req (wrong bug number)

Comment 6

[Nick Alexander :nalexander [he/him]]

rnewman: here's a fresh commit.  More to your liking?

Comment 7

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/7bd682f7d759

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8587719 [details] [review]
Pull req (wrong bug number)

rnewman reviewed on IRC.

Comment 9

[Richard Newman [:rnewman]]

Comment on attachment 8587719 [details] [review]
Pull req (wrong bug number)

Approval Request Comment
[Feature/regressing bug #]:
  Remaining reading list work.

[User impact if declined]:
  Reading list sync will be disabled by default for existing FxA users.

[Describe test coverage new/current, TreeHerder]:
  Tests added. Manually tested in context. Just landed in fx-team; this approval request assumes everything goes green.

[Risks and why]: 
  As low risk as we could make it. Some intrinsic risk, because it involves touching the Android accounts system. So it goes.

[String/UUID change made/needed]:
  None.

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7bd682f7d759

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8587719 [details] [review]
Pull req (wrong bug number)

Should be in 38 beta 2

Comment 12

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4d02b020a319

Comment 13

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-aurora/rev/2433d21ff8bb

Comment 14

[Richard Newman [:rnewman]]

Note that for this -- or the feature at all -- to be in B2, we need approval for Bug 1123389.

Comment 15

[Catalin Suciu [:csuciu]]

Verified as fixed on latest Nightly 40.0a1 and Aurora 38.0a2
Still needs to be verified on Firefox 38 Beta 4

Comment 16

[Catalin Suciu [:csuciu]]

Verified as fixe(In reply to Nick Alexander :nalexander from comment #4)
> For QA: (From the commit message.)
>     
>     The desired behaviour is: Reading List is syncing automatically if
>     Firefox Sync is syncing automatically.
>     
>     Test plan: remove all Firefox Accounts.
>     
>     1) Install old version.  Add a Firefox Account.  Ensure that Firefox
>     Sync is enabled.  Upgrade to new version.  Verify that Reading List is
>     enabled.
>     
>     2) Install old version.  Add a Firefox Account.  Manually disable
>     Firefox Sync by unchecking the checkbox in Android Settings >
>     Accounts.  (This can not be done from the Firefox Account settings
>     activity; unchecking the 4 boxes there is not the same.)  Upgrade to new
>     version.  Verify that Reading List is disabled.
>     
>     3) Install new version.  Add a new Firefox Account.  Verify that Reading
>     List is enabled.
>     
>     (There are automated tests for these scenarios.)

All three scenarios are working as expected on Beta 38.0b3  
Verifying as fixed