1123377 - Create build flag for reading list service

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Richard Newman [:rnewman]]

This will control:

* FxA setup
* Settings
* Doorhangers
* A SyncAdapter
* And many, many more, all at a low, low price.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Create build flag for reading list service on Android. v1

Defaults to off. Doesn't have any permissions/services/etc. yet, so just the stub of a flag and AppConstants.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8551385 [details] [diff] [review]
Create build flag for reading list service on Android. v1

Review of attachment 8551385 [details] [diff] [review]:
-----------------------------------------------------------------

Let's add the relevant AC_SUBST to configure.in, and add --enable-reading-list or whatever.  Desktop will want this and it's best to control features in mozconfig rather than confvars.  I think m/a/b/moz.build will need to include the new flag in DEFINES; I expect this doesn't actually pick up the flag right now.

Unless there's a reason to do this in confvars.sh only?

Comment 3

[Richard Newman [:rnewman]]

The reason I picked the confvars approach rather than a --flag:

* This isn't an external build flag that we expect people to change; this is control for when an in-development feature rides the trains.

* I explicitly don't want this interfering with desktop work, so I don't want reuse there. These two projects don't share anything.

I probably still need something in configure.in, though.

Comment 4

[Mike Hommey [:glandium]]

Note that exposing a --flag is orthogonal to enabling in mozconfig or confvars.sh. You can very well enable something without a --flag in a mozconfig.

Now, the patch as it is attached is not going to do anything whether things are added to mozconfig or confvars.sh, because it doesn't do anything explicit with the variable in configure.in. It would need to be AC_SUBSTed and tested in a moz.build to add to DEFINES, or AC_DEFINEd.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Create build flag for reading list service on Android. v2

Now with 500% more cargo-culting.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8552208 [details] [diff] [review]
Create build flag for reading list service on Android. v2

Review of attachment 8552208 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/090ab7d32dcc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/090ab7d32dcc