1149275 - Ensure newly opened conversations get focused

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

Port bug 954270 for commands and also some code from conversation.xml for starting a PM from the participant list.

Comment 1

[aleth [:aleth]]

Attachment: focusconvtb.diff

sshagarwal, does this fix the bugs you found?

Comment 2

[Suyash Agarwal (:sshagarwal)]

(In reply to aleth [:aleth] from comment #1)
> Created attachment 8585664 [details] [diff] [review]
> focusconvtb.diff
> 
> sshagarwal, does this fix the bugs you found?

The patch doesn't work for me. I am getting errors in the console:
Timestamp: 02/04/15 0:23:45
Error: TypeError: item.convView.onConvResize is not a function
Source File: chrome://messenger/content/chat/chat-messenger-overlay.js
Line: 638
Timestamp: 02/04/15 0:23:16
Error: TypeError: redeclaration of let account
Source File: chrome://messenger/content/chat/imconversation.xml
Line: 276, Column: 12
Source Code:
        var account = this._conv.account; 
Timestamp: 02/04/15 0:23:43
Error: TypeError: panel.onConvResize is not a function
Source File: chrome://messenger/content/chat/chat-messenger-overlay.js
Line: 366
Timestamp: 02/04/15 0:23:16
Error: TypeError: item.convView.updateConvStatus is not a function
Source File: chrome://messenger/content/chat/chat-messenger-overlay.js
Line: 641

And so the chat window isn't also being properly initialized.

Comment 3

[aleth [:aleth]]

Attachment: focusconvtb.diff v2

Sorry, forgot to qref.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

Review of attachment 8587544 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but let's wait for Suyash's feedback first.

Comment 5

[Suyash Agarwal (:sshagarwal)]

Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

Review of attachment 8587544 [details] [diff] [review]:
-----------------------------------------------------------------

Ya, this works for me.

Thanks :)

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/1cc7a71a0435

Comment 7

[aleth [:aleth]]

Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

[Approval Request Comment]
There doesn't seem to be any reason not to take this bug fix for 38.

Comment 8

[Kent James (:rkent)]

Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

https://hg.mozilla.org/releases/comm-aurora/rev/0ea2e2dfe99d

Comment 9

[Kent James (:rkent)]

Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

https://hg.mozilla.org/releases/comm-beta/rev/44a5a8e051cb