Closed Bug 1149275 Opened 9 years ago Closed 9 years ago

Ensure newly opened conversations get focused

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38 fixed, thunderbird39 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 40.0
Tracking Flags:
Tracking Status
thunderbird38 --- fixed
thunderbird39 --- fixed

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file, 1 obsolete file)

focusconvtb.diff v2
4.42 KB, patch
clokep
: review+
sshagarwal
: feedback+
rkent
: approval-comm-aurora+
rkent
: approval-comm-beta+
Details | Diff | Splinter Review 
Port bug 954270 for commands and also some code from conversation.xml for starting a PM from the participant list.
Attached patch focusconvtb.diff (obsolete) — — Splinter Review 
sshagarwal, does this fix the bugs you found?
Attachment #8585664 - Flags: review?(clokep)
Attachment #8585664 - Flags: feedback?(syshagarwal)
(In reply to aleth [:aleth] from comment #1)
> Created attachment 8585664 [details] [diff] [review]
> focusconvtb.diff
> 
> sshagarwal, does this fix the bugs you found?

The patch doesn't work for me. I am getting errors in the console:
Timestamp: 02/04/15 0:23:45
Error: TypeError: item.convView.onConvResize is not a function
Source File: chrome://messenger/content/chat/chat-messenger-overlay.js
Line: 638
Timestamp: 02/04/15 0:23:16
Error: TypeError: redeclaration of let account
Source File: chrome://messenger/content/chat/imconversation.xml
Line: 276, Column: 12
Source Code:
        var account = this._conv.account; 
Timestamp: 02/04/15 0:23:43
Error: TypeError: panel.onConvResize is not a function
Source File: chrome://messenger/content/chat/chat-messenger-overlay.js
Line: 366
Timestamp: 02/04/15 0:23:16
Error: TypeError: item.convView.updateConvStatus is not a function
Source File: chrome://messenger/content/chat/chat-messenger-overlay.js
Line: 641

And so the chat window isn't also being properly initialized.
Sorry, forgot to qref.
Attachment #8585664 - Attachment is obsolete: true
Attachment #8585664 - Flags: review?(clokep)
Attachment #8585664 - Flags: feedback?(syshagarwal)
Attachment #8587544 - Flags: review?(clokep)
Attachment #8587544 - Flags: feedback?(syshagarwal)
Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

Review of attachment 8587544 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but let's wait for Suyash's feedback first.
Attachment #8587544 - Flags: review?(clokep) → review+
Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

Review of attachment 8587544 [details] [diff] [review]:
-----------------------------------------------------------------

Ya, this works for me.

Thanks :)
Attachment #8587544 - Flags: feedback?(syshagarwal) → feedback+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

[Approval Request Comment]
There doesn't seem to be any reason not to take this bug fix for 38.
Attachment #8587544 - Flags: approval-comm-beta?
Attachment #8587544 - Flags: approval-comm-aurora?
Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

https://hg.mozilla.org/releases/comm-aurora/rev/0ea2e2dfe99d
Attachment #8587544 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 8587544 [details] [diff] [review]
focusconvtb.diff v2

https://hg.mozilla.org/releases/comm-beta/rev/44a5a8e051cb
Attachment #8587544 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: