Closed Bug 1149682 Opened 10 years ago Closed 10 years ago

Filter suggested tiles to only allow non-sponsored content

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Mardak, Assigned: emtwo)

References

Details

(Whiteboard: .002)

Attachments

(1 file)

v1: Don't cache (or show) sponsored suggested links.
7.32 KB, patch
adw
: review+
Details | Diff | Splinter Review 
Suggested tiles affiliate release won't have any strings to handle sponsored links in bug 1120311. Most likely we'll reuse the v3 endpoint that will down the line serve sponsored suggested tiles. We can make 38 forwards compatible by only accepting suggested links that aren't sponsored.
Assignee: nobody → msamuel

  

  



        Attachment #8586964 -
        Flags: review?(adw)

    
  

        Attachment #8586964 -
        Flags: review?(adw) → review+

    
  
Blocks: 1148859

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/01f56fe98acc

  

  



    
    

    
  
http://hg.mozilla.org/releases/mozilla-aurora/rev/f446c838a197

  

  


Iteration: --- → 40.1 - 13 Apr
Points: --- → 5

          status-firefox39:
          --- → fixed
Flags: qe-verify-
Flags: firefox-backlog+

    
    

    
  
https://hg.mozilla.org/releases/mozilla-beta/rev/98144ed917cb

  

  



          status-firefox38:
          --- → fixed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/01f56fe98acc

  

  


Status: NEW → RESOLVED
Closed: 10 years ago

          status-firefox40:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40

    
  
Blocks: 1155443

    
  
No longer blocks: 1155443

    
    

    
  
Ed, any reason this uplift did go through the normal process?
I don't remember approving this uplift.

  

  


Flags: needinfo?(edilee)

    
    

    
  
This was uplifted as part of affiliate suggested tiles bug 1148859 comment 25 that had a single landing of the suggested tiles related functionality.

  

  


Flags: needinfo?(edilee)

    
    

    
  
OK. Thanks!
Next time, please also update this bug with the uplift request (even if we do a post landing approval).
(I have been pinged about this bug).

  

  



    
  
Blocks: 1160369

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: