Closed Bug 1160369 Opened 10 years ago Closed 10 years ago

Allow for sponsored suggested tiles

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: .003 [en-US])

Attachments

(4 files, 1 obsolete file)

v1
4.18 KB, patch
adw
: review+
Details | Diff | Splinter Review
for aurora (Mardak will land)
4.19 KB, patch
Details | Diff | Splinter Review
for beta (Mardak will land)
4.53 KB, patch
Mardak
: review+
Details | Diff | Splinter Review
Verified screenshot
103.71 KB, image/png
kghim
: review+
Details
Basically reverts bug 1149682. For uplift to 39, we'll want to only allow sponsored for en-US as we don't have strings to correctly show sponsored tiles for non-en-US, and we'll want Firefox to keep filtering out the sponsored suggested tiles.
Blocks: 1160372
No longer blocks: 1160372
Whiteboard: .003
Iteration: 40.3 - 11 May → 41.1 - May 25
Attached patch v1 — — Splinter Review
Attachment #8606030 - Flags: review?(adw)
Attachment #8606030 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/b0ae961951f5
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
emtwo, can you update this patch for 39 uplift where only en-US allows sponsored suggested?
Flags: needinfo?(msamuel)
Attached patch for beta (obsolete) — — Splinter Review
Flags: needinfo?(msamuel)
Attachment #8610184 - Flags: review?(adw)
Attachment #8610184 - Flags: feedback?(edilee)
Whiteboard: .003 → .003 [en-US]
Attachment #8610184 - Flags: feedback?(edilee) → feedback+
Ed, why are there different patches for nightly, aurora, and beta on this batch of bugs for uplift? They seem the same on the couple of bugs I looked at.
Flags: needinfo?(edilee)
(In reply to Liz Henry (:lizzard) from comment #8) > Ed, why are there different patches for nightly, aurora, and beta on this > batch of bugs for uplift? The nightly and aurora patches are the same. Beta is different because we only want to turn on sponsored suggested tiles for en-US. This is because we're only beta uplifting strings for en-US to not break string freeze.
Flags: needinfo?(edilee)
Attachment #8610184 - Attachment is obsolete: true
Attachment #8610184 - Flags: review?(adw)
Attachment #8610425 - Flags: review+
Are there string changes for some of these for aurora? Changing strings on aurora also breaks the string freeze. This is one of the questions that filling out the approval request form would answer.
verified on Nightly - 41.0a1 (2015-05-26): Steps to verify: 1. Opened up new Firefox profile using ProfileSwitcher 2. Firefox Nightly First Run Page appears 3. Opened up about:config and changed browser.newtabpage.directory.source to https://people.mozilla.org/~elee/suggested.1160369.json 4. Opened up new tab by clicking on the "+" 5. Test sponsored tile correctly appears on the first unpinned location. Screenshot attached.
Status: RESOLVED → VERIFIED
Attached image Verified screenshot —
Attachment #8610915 - Flags: review+
Comment on attachment 8610025 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment: See bug 1140185 comment 11
Attachment #8610025 - Flags: approval-mozilla-aurora?
Comment on attachment 8610025 [details] [diff] [review] for aurora (Mardak will land) approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610025 - Flags: approval-mozilla-aurora?
Confirming the fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using the STR from comment 11 with latest Aurora, build ID: 20150528004000.
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: