1149954 - Significant performance regression on the certain demo without HWA.

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Alice0775 White]

Significant performance regression on the test[1] without HWA.

[1]https://developer.mozilla.org/media/uploads/demos/p/a/paulrouget/8bfba7f0b6c62d877a2b82dd5e10931e/hacksmozillaorg-achi_1334270447_demo_package/HWACCEL/

30fps+ on Firefox37 With HWA
  0fps on Firefox38 without HWA

Comment 1

[Alice0775 White]

oops,
30fps+ on Firefox37.0 without HWA
  0fps on Firefox38b1 without HWA


Regression pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d94b6a6469b4&tochange=cbcafb38ad62

Comment 2

[Alice0775 White]

Reproduced on windows7 Sp1 Windows8.1 update and Windows10TP10049.
Not reproduced on ubuntu14.04.
Not tested on Mac.

Via local build
Last Good: 08434d415b5c
First Bad: fcb277a52bdd

Regressed by:
fcb277a52bdd	George Wright — Bug 1042291 - Add a CanvasDrawObserver which observes the first few seconds/frames of a Canvas2D's lifetime to determine using a heuristic if it should be software or GPU backed. r=gw280, r=snorp


FYI,
Gecko profiler does not work well. Because if Gecko Profiler installed, the demo is working fine.

Comment 3

[Alice0775 White]

It was fixed when it was in Aurora37.0a2 cycle (and maybe it was in Beta36 cycle). 
However, unfortunately, It has not been fixed in Nightly 38 and later.

Fixed range(aurora)
https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=5a89d54ef5e9&tochange=81a5207ffc75

Fixed by Bug 1124249 in in Aurora37.0a2 and Beta36 only

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

I hate uplifts.  Bug 1124249 never landed in trunk (38 at the time.)  Will get a 38-40 patch.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Only Skia canvases need be considered for acceleration. Carry r=jmuizelaar from bug 1124249

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 38+.  
Once we land this on m-c it would be good to get extra verification from QE.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f806e79f1c9a

After verification, I will ask for uplifts.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6757cd28df3

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e6757cd28df3

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8586935 [details] [diff] [review]
Only Skia canvases need be considered for acceleration. Carry r=jmuizelaar from bug 1124249

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: 13% of beta crashes.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: We shouldn't be going into SkiaGL on the desktop, so this just enforces it.
[String/UUID change made/needed]: n/a

This got fixed in bug 1124249 during 38, but only landed on 36 and 37, and never on 38.  Now that it has landed on 40, we want to make sure we plug in the gap and land it on 38 and 39.  It already went through the previous beta as 37, so the risk should be small.

Comment 11

[Catalin Varga [QA][:VarCat]]

I verified this fix on:

FF 40
Build id: 20150406030204
OS: Win 7 x64, Ubuntu 14.04 x64

However the verification on Mac Os X was not possible due to bug 1151492

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8586935 [details] [diff] [review]
Only Skia canvases need be considered for acceleration. Carry r=jmuizelaar from bug 1124249

Fix a top crash, taking it. Should be in 38 beta 2 (likely) or 3 (worst case scenario)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/95103b517141

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4e6da60e6d4

Comment 15

[Petruta Horea [:phorea], Desktop QA]

1fps using Firefox 38 beta 1 under Win 7 64-bit.
29+pfs using Firefox 38 beta 2
30fps with latest Aurora 39.0a2
29+fps with latest Nightly 40.0a1