1149990 - Cannot set currentTime/resume transitions that are finished

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Patrick Brosset <:pbro>]

STR:
- Open https://dl.dropboxusercontent.com/u/714210/transition.html
- Click on the red <div>
- Wait for the width/height transitions to end
- Open the web console

On click of the <div>, I store both Animation objects (retrieved via el.getAnimations()) on the global scope, in the `animations` variable.

So, with the web console opened, you can try to change the currentTime of either the width or height transitions, or play/pause, change the playbackRate, ... nothing seems to work.

It looks like once finished, transitions are put in a state where nothing works anymore.
Executing animations[0].playState however does return "finished".

For info, trying to change the currentTime while the transition is playing does work as expected.

Also for info, modifying css animations (not transitions) after they're finished does work too.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: possible patch

This works, although I'm not sure we should be calling SetIsFinishedTransition in two different places.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8586755 [details] [diff] [review]
possible patch

Perhaps drop the default argument value and just explicitly pass true when needed?

Comment 3

[Patrick Brosset <:pbro>]

I'd really want this to land sooner rather than later. Is the current r+'d patch ok to go? Or are there other things to do here?

Comment 4

[Jonathan Watt [:jwatt]]

I will land this soon, but the tree has been closed recently. I'll try again tomorrow.

Comment 5

[Jonathan Watt [:jwatt]]

And as soon as I finally decide to say that the tree reopens...

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f011e332b68

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Any chance of a test for this?

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2f011e332b68

Comment 8

[Jonathan Watt [:jwatt]]

(In reply to Brian Birtles (:birtles) from comment #6)
> Any chance of a test for this?

Bug 1157053.