Closed Bug 1157053 Opened 8 years ago Closed 8 years ago

Test restarting of finished transitions

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

No description provided.
Summary: Test restarting of transitions → Test restarting of finished transitions
Attached patch patchSplinter Review
Attachment #8595655 - Flags: review?(bbirtles)
Blocks: 1149990
Comment on attachment 8595655 [details] [diff] [review]
patch

Review of attachment 8595655 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if this should be in test_animation-finishing.html since it's not really testing the finished promise? Perhaps it should even be in the mozilla folder since it's really testing a Gecko-specific bug? Up to you.

Also, I don't know if we need to test the reversing case but it probably doesn't hurt.

r=me with comments addressed assuming you've tested that the test fails without the patch from bug 1149990 applied.

::: dom/animation/test/css-transitions/test_animation-finished.html
@@ +48,5 @@
> +    animation.playbackRate = -1;
> +    return animation.finished;
> +  }).then(t.step_func(function() {
> +    animation.play();
> +    assert_equals(animation.currentTime, ANIM_DELAY_MS + ANIM_DUR_MS,

Put a FIXME comment here that when animation.effect.computedTiming.endTime is available (bug 1108055) we should use that here?

@@ +50,5 @@
> +  }).then(t.step_func(function() {
> +    animation.play();
> +    assert_equals(animation.currentTime, ANIM_DELAY_MS + ANIM_DUR_MS,
> +                  'Replaying a finished reversed transition should reset ' +
> +                  'its currentTime to the animation duration');

Nit: Strictly speaking it's more the "end of the effect" rather than the animation duration.
Attachment #8595655 - Flags: review?(bbirtles) → review+
https://hg.mozilla.org/mozilla-central/rev/f57c4c6a9ad7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.