Closed
Bug 1150151
Opened 9 years ago
Closed 9 years ago
Get e10s browser-chrome and reftests green on Linux debug
Categories
(Testing :: Mochitest, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(3 files)
4.63 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
1.04 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
1.20 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
We're very close to being able to do this. Just need to disable a couple tests and tweak the leak threshold for reftests.
Assignee | ||
Comment 1•9 years ago
|
||
This patch disable some tests. One is a pre-existing timeout that happens more often in debug. Then there are docshell leaks in a few social tests. Finally, there's bug 1150036, which is kinda weird.
Attachment #8586903 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•9 years ago
|
||
Adds an intentional crash annotation.
Attachment #8586904 -
Flags: review?(continuation)
Assignee | ||
Comment 3•9 years ago
|
||
Bumps up the reftest leak threshold for content processes. I made it the same as the one we use for mochitests.
Attachment #8586905 -
Flags: review?(continuation)
Comment 4•9 years ago
|
||
Comment on attachment 8586903 [details] [diff] [review] disable failing tests Review of attachment 8586903 [details] [diff] [review]: ----------------------------------------------------------------- Awesome!
Attachment #8586903 -
Flags: review?(dtownsend) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8586904 [details] [diff] [review] add crash annotation Review of attachment 8586904 [details] [diff] [review]: ----------------------------------------------------------------- Hooray!
Attachment #8586904 -
Flags: review?(continuation) → review+
Comment 6•9 years ago
|
||
Are you actually seeing any leaks? I looked at the C and R tests in this try run and it didn't look like there were any: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3dbb0b63fb2 Though I'm not sure how that's possible.
Comment 7•9 years ago
|
||
Oh right, that's an older run without Reftests being run in e10s. I'll look at the newer one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49e74e9ac0fd
Comment 8•9 years ago
|
||
Comment on attachment 8586905 [details] [diff] [review] set reftest leak threshold Review of attachment 8586905 [details] [diff] [review]: ----------------------------------------------------------------- The leaks look the same as for Mochitests, so I suppose it makes sense to make the threshold the same.
Attachment #8586905 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 9•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7c811369af6 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/2402d1757afe remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d7284fd06b4
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a7c811369af6 https://hg.mozilla.org/mozilla-central/rev/2402d1757afe https://hg.mozilla.org/mozilla-central/rev/4d7284fd06b4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•6 years ago
|
Component: Mochitest Chrome → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•