1150160 - Support import of apps as memory blobs.

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: import-memory-blob.patch

Justin, do you mind testing that for lightsaber? That removes the need to save blobs on the sd-card and to grand the sd-card permissions to all apps.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8586915 [details] [diff] [review]
import-memory-blob.patch

Review of attachment 8586915 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work for me. Thanks!

Comment 4

[Marco Castelluccio [:marco]]

Comment on attachment 8586915 [details] [diff] [review]
import-memory-blob.patch

Review of attachment 8586915 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/ImportExport.jsm
@@ +37,5 @@
>  const PR_CREATE_FILE = 0x08;
>  const PR_TRUNCATE    = 0x20;
>  
>  function debug(aMsg) {
> +//#ifdef DEBUG

I guess you used this to debug problems while working on the patch, but should be removed now.

@@ +246,5 @@
> +    return new Promise((aResolve, aReject) => {
> +      let reader = Cc['@mozilla.org/files/filereader;1']
> +                     .createInstance(Ci.nsIDOMFileReader);
> +      reader.onloadend = () => {
> +        Cu.import("resource://gre/modules/osfile.jsm");

Nit: could you use a lazy module getter?

@@ +248,5 @@
> +                     .createInstance(Ci.nsIDOMFileReader);
> +      reader.onloadend = () => {
> +        Cu.import("resource://gre/modules/osfile.jsm");
> +        let path = OS.Path.join(OS.Constants.Path.tmpDir, "blob-" +
> +                                this._tmpId + ".zip");

You could use openUnique to generate a file with a unique file name: https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/OSFile.jsm/OS.File_for_the_main_thread#OS.File.openUnique%28%29

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/557609749a57

Comment 6

[Marco Castelluccio [:marco]]

The file should be closed after being opened here: https://hg.mozilla.org/integration/b2g-inbound/rev/557609749a57#l1.55

Since you've opened it, you could also directly use |file.write| instead of |writeAtomic|.

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/a586f075e7d0 for Windows "Memory blob processed. - got "[object Object]", expected "InvalidZip""

Comment 8

[[:fabrice] Fabrice Desré]

fixed the issues, try run at :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20cb8264e40d

pushed:
https://hg.mozilla.org/integration/b2g-inbound/rev/f69003e17520

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f69003e17520