Ship Fira and Charis SIL with Reader View for know character supported locales

RESOLVED WONTFIX

Status

()

P3
normal
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: mmaslaney, Assigned: bwinton)

Tracking

(Depends on: 1 bug)

38 Branch
Points:
5
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Ship Fira and Charis with Reader View for know supported locales.

SPECS

Charis Spec: http://invis.io/4V2K8JN9E

Fira Spec: http://invis.io/JH26PPWT5


FONTS & WEIGHTS TO INCLUDE:

Charis SIL – Regular, Bold, Italic, Bold Italic

Fira – Book, Bold, Book Italic, Bold Italic

Fira Monotype – Regular


FIRA Language SUPPORT: 

• English
• Spanish
• German 
• French 
• Russian 
• Dutch 
• Portuguese 
• Italian
• Greek
• Turkish
• Swedish
• Polish
• Swedish
• Danish
• Czech
• Indonesian
• Filipino
• Norwegian
http://www.carrois.com/en/fira-3-1/


CHARIS Language Support

http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=CharisSIL_Technical#38fec032


CSS:

font-family: "Charis SIL",Georgia,"Times New Roman",serif;

font-family: "Fira Sans",Helvetica,Arial,sans-serif
(Assignee)

Comment 3

3 years ago
Created attachment 8598108 [details] [diff] [review]
Attempt number 1.

So, how does this look as a way of getting locale-dependant font choices?
Is there a better way of doing this?

(I still need to adjust the font-sizing buttons, so this isn't ready for review, but if the approach looks good and there's stuff I should be fixing, I would be happy to fix that now, too.)
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Attachment #8598108 - Flags: feedback?(margaret.leibovic)
Attachment #8598108 - Flags: feedback?(gijskruitbosch+bugs)
Attachment #8598108 - Flags: feedback?(dao)

Updated

3 years ago
Iteration: --- → 40.2 - 27 Apr
Flags: qe-verify?
Flags: firefox-backlog+
(Assignee)

Comment 4

3 years ago
(I think this might be tricky.)
Points: --- → 5
Comment on attachment 8598108 [details] [diff] [review]
Attempt number 1.

Review of attachment 8598108 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for writing a patch!

Sadly, I foresee problems with this:

0) the browser locale != the text on the page. Basically, if I'm using a locale where these fonts don't work, but view an English article, wouldn't I want the other font? Or would it be confusing? What if I used en-US but read an article in a language where the font doesn't work?
1) While our localizers are awesome, I don't know how many will be able to make good choices for these values for their locale anyway
2) I don't think our l10n infrastructure is equipped for localized CSS files, unfortunately. :Pike would know for sure.
Attachment #8598108 - Flags: feedback?(gijskruitbosch+bugs) → feedback-
(Assignee)

Comment 7

3 years ago
Pike, can you give me any ideas on how to handle localizing CSS files (if such a thing is possible or desirable)?
Flags: needinfo?(l10n)

Comment 8

3 years ago
I'm a bit afk-pto, but quickly:

You don't care about UI locale, but content locale. Thus you should use the language detector logic we had for in-page-translation, and based on that language, insert CSS into the reader-view page to either use the shipped fonts, or default OS fonts.
Flags: needinfo?(l10n)

Updated

3 years ago
Iteration: 40.2 - 27 Apr → 40.3 - 11 May
(Assignee)

Updated

3 years ago
Target Milestone: Firefox 38 → Firefox 40
Comment on attachment 8598108 [details] [diff] [review]
Attempt number 1.

(In reply to :Gijs Kruitbosch (mostly away until May 5th) from comment #6)
> 0) the browser locale != the text on the page.

(In reply to Axel Hecht [:Pike] from comment #8)
> You don't care about UI locale, but content locale.

Absolutely.

I also think we'd want to avoid letting localizers write CSS.
Attachment #8598108 - Flags: feedback?(dao) → feedback-
(Assignee)

Comment 10

3 years ago
Okay, so how do you all feel about the following approach:
If we can detect the content locale(s), and they are all in a whitelist of known-good locales, we use the custom fonts.

Alternatively, any other suggestions would be very welcome.  :)
UPDATE:

I found "Noto", a typeface with both Serif and Sans Serif faces that has global support. 

Source: 
https://www.google.com/get/noto/

Could we utilize this instead?
Flags: needinfo?(l10n)
Flags: needinfo?(gijskruitbosch+bugs)

Comment 13

3 years ago
We use Noto fonts on Firefox OS for a few languages. https://github.com/mozilla-b2g/moztt/ in combination with all.js for b2g gives you a good idea which languages should be rendered in which font, according to our community.

Also, all those fonts in the download are 360M, didn't try how much of that is the actual font data.
Flags: needinfo?(l10n)
(In reply to Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com) from comment #11)
> UPDATE:
> 
> I found "Noto", a typeface with both Serif and Sans Serif faces that has
> global support. 
> 
> Source: 
> https://www.google.com/get/noto/
> 
> Could we utilize this instead?

I don't know; seems like Pike just gave a good answer, though I'll say that 360M is way, way too much to be shipping with Firefox just for slightly nicer fonts. For concrete guidelines as to size, I'd recommend talking to Gavin.
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8598108 - Flags: ui-review?(mmaslaney) → ui-review+

Updated

3 years ago
Iteration: 40.3 - 11 May → 41.1 - May 25

Updated

3 years ago
Attachment #8598108 - Flags: feedback?(margaret.leibovic)
I think the outcome here and through discussion (in fx-dev among other places) was essentially wontfix. If I misremember or am wrong, do correct me!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Component: General → Reader Mode
Product: Firefox → Toolkit
Resolution: --- → WONTFIX
Target Milestone: Firefox 40 → ---
You need to log in before you can comment on or make changes to this bug.