1150423 - [System] expose device type to system app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

To enable multiple device type in one system app, we should expose device type to system app. The following is our plan:

1. Create a FeatureDetector module which wraps feature detections functions, like navigator.getFeature(), document.implementation.hasFeature(xxx, xxx) and device type.
2. use system app's build script to expose __DEVICE_TYPE to window object
3. register FeatureDetector's deviceType to service.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

BTW, please modify the navigator.getFeature used by InputWindowManager[1] to FeatureDetector

[1] https://github.com/mozilla-b2g/gaia/blob/bfe504b49533fb268c5ddda99c606aa66442b313/apps/system/js/input_window_manager.js#L271-L280

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] shamenchens:Bug1150423-ExposeDeviceType > mozilla-b2g:master

Comment 3

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8587327 [details] [review]
[gaia] shamenchens:Bug1150423-ExposeDeviceType > mozilla-b2g:master

Alive, this patch introduce FeatureDetector to system app and exposes device type/device memory to service, would you review changes in system app? thanks!

Ricky, we tend to replace some variable in build time, and I add `matchFileContentInZip` to helper function for build integration test, would you review changes in build system part? thanks!

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8587327 [details] [review]
[gaia] shamenchens:Bug1150423-ExposeDeviceType > mozilla-b2g:master

LGTM for build system part. Please fix the nit before landing.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8587327 [details] [review]
[gaia] shamenchens:Bug1150423-ExposeDeviceType > mozilla-b2g:master

r+ with nits, feel free to flag review again if you have problem with the change.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/820bc8fe46ce346aa38a1bb0f147bbec8d16377f