1150552 - layers.acceleration.draw-fps does not render correctly.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jukka Jylänki]

Attachment: layers-acceleration-drawfps.png

Enabling the pref layers.acceleration.draw-fps on Windows 8.1 does not render properly on Windows 8.1, but part of the fps counter is cut off. See the attached screenshot for an example.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I believe this is a Graphics bug.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:mchang, maybe you can help here?

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to Jukka Jylänki from comment #0)
> Created attachment 8587452 [details]
> layers-acceleration-drawfps.png
> 
> Enabling the pref layers.acceleration.draw-fps on Windows 8.1 does not
> render properly on Windows 8.1, but part of the fps counter is cut off. See
> the attached screenshot for an example.

Does this happen all the time or only during webgl content? For example, just browsing reddit or something, does it still occur.

Comment 4

[Jukka Jylänki]

It does occur on all pages, e.g. reddit.com as well. If I resize the window or maximize the window, it looks like it does one correct full refresh, but anything it prints after that is again cut to half.

Comment 5

[Jukka Jylänki]

Bisected this to have broken by this regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=035a951fc24a&tochange=f1f48ccb2d4e .

While bisecting, I notice that there are even two different bugs related to the fps counter:

1) the fps counter display is cut in half. That is shown in the screenshot in comment 0. This does not always happen, but when the browser window is maximized on Windows, it happens always. When the browser is in windowed mode, the fps counter seems to be rendered in full sometimes, and other times it is cut in half as well.

2) The fps counter does not continously update/rerender itself, but is stale and shows the same number. Resizing the browser window causes it to do one updated render.

Comment 6

[Kelsey Gilbert [:jgilbert]]

This is really important for people developing full-framerate content, particularly with WebGL.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Benoit, can you take a look?

Comment 8

[Benoit Girard (:BenWa)]

I wont get to it right away (unless we think it's a rush) but I'll take a look soon.

Comment 9

[Benoit Girard (:BenWa)]

Attachment: patch

This patch cheats a little bit but I think that's ok. It will invalidate for the *next* frame but since the FPS is active every frame then each frame keeps invalidating the next and so on. Note that this provides invalidation for the next frame but it doesn't request it so it doesn't affect how we schedule the frames, it just makes sure that we present the FPS counter on the next partial present.

If we wanted to do this properly we would have to check if we had any debug overlay active in the BeginFrame call. I could be convinced to write that patch but IMO this is better.

Comment 10

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8645040 [details] [diff] [review]
patch

Review of attachment 8645040 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe just comment about how this is invalidating for next time?

Comment 11

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1150552 - Fix partial present bug with FPS counter. r=mattwoodrow

Bug 1150552 - Fix partial present bug with FPS counter. r=mattwoodrow

Comment 12

[Benoit Girard (:BenWa)]

Comment on attachment 8645070 [details]
MozReview Request: Bug 1150552 - Fix partial present bug with FPS counter. r=mattwoodrow

Bug 1150552 - Fix partial present bug with FPS counter. r=mattwoodrow

Comment 13

[Benoit Girard (:BenWa)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abb912bb6069

Comment 14

[Benoit Girard (:BenWa)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/803ba9e9abc703889ce73f0d4f16a2b411de2586
changeset:  803ba9e9abc703889ce73f0d4f16a2b411de2586
user:       Benoit Girard <[e-mail]>
date:       Fri Aug 07 14:11:18 2015 -0400
description:
Bug 1150552 - Fix partial present bug with FPS counter. r=mattwoodrow

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/803ba9e9abc7