Set TabsPanel.TabsPanelToolbar attributes in xml, rather than code

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: mking, Mentored)

Tracking

unspecified
Firefox 40
All
Android
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

Currently, some attributes seem to be defined dynamically:

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tabs/TabsPanel.java?rev=83ffa6446310#355

Move these values to layout/tabs_panel_default.xml and make sure nothing changes in the TabsPanel (click the tab count button). Test on tablet too if you can!

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
Assignee

Comment 1

4 years ago
Anybody taking this? I'd like to work on this one. Thanks!
Hey, Matt - welcome aboard! :) Go ahead and get started - whenever you upload your first patch, I'll assign you to the bug.
Assignee

Comment 3

4 years ago
I also removed setLayoutParams in TabsPanel, since it seemed as unnecessary as the call in TabsPanelToolbar
Assignee

Updated

4 years ago
Attachment #8589590 - Flags: review?(michael.l.comella)
Assignee: nobody → mking
Comment on attachment 8589590 [details] [diff] [review]
Set TabsPanel.TabsPanelToolbar attributes in xml, rather than code

Review of attachment 8589590 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8589590 - Flags: review?(michael.l.comella) → review+
If you'd like to get working on another bug, perhaps bug 952290 or bug 1105271 strikes your fancy? If not, let me know and I can dig up some more bugs.
Assignee

Updated

4 years ago
Keywords: checkin-needed
Assignee

Comment 7

4 years ago
Thanks so much for the help :mcomella, and I'm taking a look at those other bugs now!
Hi,

sorry this didn't apply:

renamed 1150621 -> tabspaneltoolbar-attributes.patch
applying tabspaneltoolbar-attributes.patch
unable to find 'mobile/android/base/resources/layout-large-land-v11/tabs_panel_sidebar.xml' for patching
2 out of 2 hunks FAILED -- saving rejects to file mobile/android/base/resources/layout-large-land-v11/tabs_panel_sidebar.xml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh tabspaneltoolbar-attributes.patch

could you take a look, thanks!
Flags: needinfo?(mking)
Keywords: checkin-needed
Assignee

Updated

4 years ago
Flags: needinfo?(mking)
Attachment #8591675 - Flags: review?(michael.l.comella)
Assignee

Comment 10

4 years ago
Weird, I don't know why that file only exists locally. Submitted a new patch. Thanks!
Comment on attachment 8591675 [details] [diff] [review]
Set TabsPanel.TabsPanelToolbar attributes in xml, rather than code

Review of attachment 8591675 [details] [diff] [review]:
-----------------------------------------------------------------

That file was removed in a previous changeset (bug 1106935, I believe, which just landed) - thanks again, Matt!
Attachment #8591675 - Flags: review?(michael.l.comella) → review+
Attachment #8589590 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8bcd9d38bb20
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.