1150904 - [gonk-lmr1] update platform_build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Without 'frameworks/rs', there is a compile issue. Update platform_build not to build libhwui can solve this error.

--
make: *** No rule to make target `out/target/product/hammerhead/obj/SHARED_LIBRARIES/libRS_intermediates/export_includes', needed by `out/target/product/hammerhead/obj/SHARED_LIBRARIES/libhwui_intermediates/import_includes'.  Stop

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Disable libhwui and hwuitest.

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8587989 [details] [review]
Disable libhwui and hwuitest.

Michael, could you review this PR? You could also see bug 1150345 comment 7 about the dependency of libhwui. Thanks!

Comment 3

[Michael Wu [:mwu]]

I think tests are always built in engineering builds, so hwuitest would automatically get built and pull in libhwui.

The other dependency on libhwui is libtilerenderer, but I haven't found any dependencies on libtilerenderer.

So, I think I'd like to see if disabling just hwuitest works. If it does, let's do that. If not, I'll stamp the current PR. Thanks!

Comment 4

[Keven Kuo [:kkuo]]

Comment on attachment 8587989 [details] [review]
Disable libhwui and hwuitest.

Due to MR1 build is blocked by this issue, please land this first.
--
Keven

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/platform_build/commit/5fb8cf8d2cd889960d2060224ee52b9825516a40

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/platform_build/commit/7fb54fb0cf6d1ef7cdb8578fa714a0b8de4a6b74

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Disable libhwui and hwuitest.

Michael, could you have a review to this PR? Thanks!

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 8590914 [details] [review]
Disable libhwui and hwuitest.

I already reviewed this in comment 3 and suggested a change. I just verified that the suggestion works, so please update the PR.

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8590914 [details] [review]
Disable libhwui and hwuitest.

Michael, Just disable hwuitest does work. I also update the patch to fix error in [1]. I didn't get this error when I working on nexus-5-l, but I can see this error on emulator-l when it is building on my PC. With this fix, the issue can be solved. Could you review this patch? Thanks!

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=1687768&repo=b2g-inbound

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 8590914 [details] [review]
Disable libhwui and hwuitest.

Looks good, thanks

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/platform_build/commit/6b0721ca0e92788df30daf8f7a5fb2863544f9c8