Closed Bug 1150904 Opened 5 years ago Closed 5 years ago

[gonk-lmr1] update platform_build

Categories

(Firefox OS Graveyard :: GonkIntegration, defect, major)

x86_64
Gonk (Firefox OS)
defect
Not set
major

Tracking

(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S10 (17apr)
blocking-b2g 2.2+
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: seinlin, Assigned: seinlin)

References

Details

Attachments

(1 file, 1 obsolete file)

Without 'frameworks/rs', there is a compile issue. Update platform_build not to build libhwui can solve this error.

--
make: *** No rule to make target `out/target/product/hammerhead/obj/SHARED_LIBRARIES/libRS_intermediates/export_includes', needed by `out/target/product/hammerhead/obj/SHARED_LIBRARIES/libhwui_intermediates/import_includes'.  Stop
Assignee: nobody → kli
Blocks: 1147266
Attached file Disable libhwui and hwuitest. (obsolete) —
Comment on attachment 8587989 [details] [review]
Disable libhwui and hwuitest.

Michael, could you review this PR? You could also see bug 1150345 comment 7 about the dependency of libhwui. Thanks!
Attachment #8587989 - Flags: review?(mwu)
I think tests are always built in engineering builds, so hwuitest would automatically get built and pull in libhwui.

The other dependency on libhwui is libtilerenderer, but I haven't found any dependencies on libtilerenderer.

So, I think I'd like to see if disabling just hwuitest works. If it does, let's do that. If not, I'll stamp the current PR. Thanks!
blocking-b2g: --- → 2.2+
Comment on attachment 8587989 [details] [review]
Disable libhwui and hwuitest.

Due to MR1 build is blocked by this issue, please land this first.
--
Keven
Attachment #8587989 - Flags: review?(mwu) → review+
https://github.com/mozilla-b2g/platform_build/commit/5fb8cf8d2cd889960d2060224ee52b9825516a40
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Michael, could you have a review to this PR? Thanks!
Attachment #8587989 - Attachment is obsolete: true
Attachment #8590914 - Flags: review?(mwu)
Comment on attachment 8590914 [details] [review]
Disable libhwui and hwuitest.

I already reviewed this in comment 3 and suggested a change. I just verified that the suggestion works, so please update the PR.
Attachment #8590914 - Flags: review?(mwu)
No longer blocks: 1147266
Blocks: 1153631
Comment on attachment 8590914 [details] [review]
Disable libhwui and hwuitest.

Michael, Just disable hwuitest does work. I also update the patch to fix error in [1]. I didn't get this error when I working on nexus-5-l, but I can see this error on emulator-l when it is building on my PC. With this fix, the issue can be solved. Could you review this patch? Thanks!

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=1687768&repo=b2g-inbound
Attachment #8590914 - Flags: review?(mwu)
Comment on attachment 8590914 [details] [review]
Disable libhwui and hwuitest.

Looks good, thanks
Attachment #8590914 - Flags: review?(mwu) → review+
https://github.com/mozilla-b2g/platform_build/commit/6b0721ca0e92788df30daf8f7a5fb2863544f9c8
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S10 (17apr)
You need to log in before you can comment on or make changes to this bug.