1150961 - Installed hosted apps show lock icon on empty line in task manager

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: twitter-lock-icon-task-manager.png

Missed in bug 1149448, 

STR: 
1. Install twitter (or other hosted app) from Marketplace
2. Open app
3. Long-press home button to show task manager

Expected: Task manager shows a single card with title 'Twitter' and nothing on the subtitle line below. 

Actual: The subtitle line has the lock icon on an empty line with no URL next to it.

Comment 1

[Sam Foster [:sfoster] (he/him)]

In bug 1149448, I added a child element to the .subTitle container to properly handle RTL and the LTR url we should in the subtitle. That means that the #cards-view .card p.subtitle:not(:empty) rule always matches here for secure hosted apps. 

Repros on master and v2.2 since 1149448 landed: requesting blocking status for this follow-up.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Patch in the works for this.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:task-manager-lock-icon-hosted-apps-bug-1150961 > mozilla-b2g:master

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8588194 [details] [review]
[gaia] sfoster:task-manager-lock-icon-hosted-apps-bug-1150961 > mozilla-b2g:master

The :empty selectors match always when I added the subtitle-url. Changed it up to add a show-subtitle class on the card. The unit tests were all using a http:// url which is the one case where we do want to show the url/subtitle which I think was not the intention for the non-browser case tests here, so I changed that to use app://.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8588194 [details] [review]
[gaia] sfoster:task-manager-lock-icon-hosted-apps-bug-1150961 > mozilla-b2g:master

All good! Sorry for the review delay.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8588194 [details] [review]
[gaia] sfoster:task-manager-lock-icon-hosted-apps-bug-1150961 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): RTL (follow-up from bug 1149448)
[User impact] if declined: Hosted apps will show lock icon on empty line in card view
[Testing completed]: Tested on device, unit tests updated
[Risk to taking this patch] (and alternatives if risky): Low risk, this patches an issue introduced by incomplete solution in 1149448. We should ship both or neither. 
[String changes made]: None

Comment 7

[bhavana bajaj [:bajaj]]

waiting for master landing here before addressing the branch uplift request.

Comment 8

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/1192f05d1ce7027c5f6e6053b4f652ad29031466

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9b7bbed86f6a78846962f91fd076489a9c29bd86

Comment 10

[Hermes Cheng (inactive after July 27, 2015)]

*v2.2
Build ID               20150414162502
Gaia Revision          16e948bfaaa15dbc0200135d52f16257b4eab193
Gaia Date              2015-04-14 21:08:25
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0eec28e78eb1
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.201515
Firmware Date          Tue Apr 14 20:15:24 EDT 2015
Bootloader             L1TC000118D0


*master
Build ID               20150414160204
Gaia Revision          8e28588496f82f8f069c171c65842d622b9d8d7d
Gaia Date              2015-04-14 18:43:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/de27ac2ab94f
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.194002
Firmware Date          Tue Apr 14 19:40:12 EDT 2015
Bootloader             L1TC000118D0