1151052 - [RTL] [SMS] send icon in compose is flipped

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Tiffanie Shakespeare [:tif]]

Attachment: sms.pdf

STR:
1. Change language to Arabic
2. Go to SMS and tap new message
3. Observe the send icon (paper plane) 

Actual
The icon is mirrored from LTR languages

Expected
The icon keep its LTR orientation

Comment 1

[Julien Wajsberg [:julienw]]

We made this on purpose (in bug 1053708) because this is in our opinion more logical to RTL users.

I'd like to add that the send button is quite a beast (see attachment 8501738 [details] for the various cases including DSDS) and so it would be risky to revert this now.

Who can decide here?

Comment 2

[Dylan Oliver [:doliver]]

Thanks Julien. It's not worth the additional risk at this point. I think it makes at least as much sense pointing to the left as it is now. 

Unblocking for 2.2 -- I'll leave the ni? for Stephany to review & comment if this is something we'd need to tackle in the future.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Lancy: please follow this bug and make sure test case reflects final decision. Thanks!

Comment 4

[Lancy(Leave from Mozilla)]

Delphine,
OK, the related test case has been updated.

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15374/

Comment 5

[Lancy(Leave from Mozilla)]

This issue still exist on the latest Flame 2.2 and Flame 3.0 build.
Reproducing rate:10/10

Flame 2.2 build:
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.195227
Firmware Date          Tue Apr  7 19:52:39 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build:
Build ID               20150407160201
Gaia Revision          84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gaia Date              2015-04-07 17:33:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/078128c2600a
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.193600
Firmware Date          Tue Apr  7 19:36:12 EDT 2015
Bootloader             L1TC000118D0

Comment 6

[Julien Wajsberg [:julienw]]

From what I understand, the "send" button is like an arrow to "outside" and that's why the current "flip" makes more sense in my opinion.

Maybe SMS designers Fang and Jenny could also comment on the UX/Design side.

Comment 7

[Stephany Wilkes]

The spec is very clear about this and why, and this doesn't follow the spec (which was done in concert with members of the Mozilla Arabic community who are native speakers). Removing UX flags since we covered this thoroughly in the UX spec.

Comment 8

[Julien Wajsberg [:julienw]]

Stephany, let me disagree.

The spec says:

DO NOT MIRROR
- Most Icons (except those that indicate direction, such as arrows)

Well, this is IMO an arrow. That's why I wanted to ask Fang, to know if this is really thought as an arrow, or if it just happens to look like an arrow.

Comment 9

[Fang Shih [:fang]]

Hi Julien, 

Thanks for the double confirmed. It's actually an icon that happens to look like an arrow. The original concept is to use paper airplane to symbolize the sent icon. 
Thanks!

Comment 10

[Julien Wajsberg [:julienw]]

OK thanks Fang.

We'll do the change then.

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

Lancy: please don't update test cases until final decision is taken in a bug... that's just extra work for nothing ;) Now that decision is taken (see comment 10) you can update the test case accordingly. thanks

Comment 12

[Lancy(Leave from Mozilla)]

Delphine,
OK, I have updated the related test case according to the final decision.

Comment 13

[Elie]

Attachment: Problem cannot be reproduced.png

This Problem cannot be reproduced on latest build of Flame 2.2, Flame 3.0, N5 2.2 and N5 3.0. Per comment 8 and comment 9, the paper airplane should be left-aligned and mirrored, and which is the phenomenon on device now.
See attachment: Problem cannot be reproduced.png
Rate: 0/5

Device information:
Flame 2.2 Build ID: 20150526162504
Flame 3.0 Build ID: 20150526160204
Nexus5 2.2 Build ID: 20150526162504
Nexus5 3.0 Build ID: 20150526160204

Comment 14

[Tiffanie Shakespeare [:tif]]

Hey Elie - Fang's comment 9 is saying that the icon should be the SAME in both RTL and LTR languages (i.e. not flipped). 

As your screenshot shows, it's still flipping in RTL languages and thus still reproducible. Thanks!

Comment 15

[Elie]

(In reply to Tiffanie Shakespeare from comment #14)
> Hey Elie - Fang's comment 9 is saying that the icon should be the SAME in
> both RTL and LTR languages (i.e. not flipped). 
> 
> As your screenshot shows, it's still flipping in RTL languages and thus
> still reproducible. Thanks!

Hey Tiffanie,
Thanks for your soft reminder. Yes, this issue can be reproduced. We had opened one same bug 1139732, but that bug had been marked as INVALID, that makes me confused.

Hi Julien,
This issue can be reproduced on latest build of Flame 2.2/3.0 and Nexus5 2.2/3.0 by STRs in comment 0. Could you tell us how is this bug going at your side?

Device information:
Flame 2.2 Build ID: 20150527002504
Flame 3.0 Build ID: 20150527160204
Nexus5 2.2 Build ID: 20150527002504
Nexus5 3.0 Build ID: 20150527160204

Comment 16

[Julien Wajsberg [:julienw]]

The bug is not priorized so unless you tell me this confuses a lot of people speaking a RTL-language this won't be worked on soon as we have higher priority tasks to do currently.

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

This does not follow the UX specs for 2.2 (see comment 9 and comment 10) BUT as per comment 2, Dylan decided not to bock 2.2 on this. So I'm not going to try and prioritize this bug more given we're so late in the cycle. thanks

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

(taking out nom' - not intended)

Comment 19

[Alissa（leave from Mozilla）]

This issue can be reproduced on latest build of AriesKK_V2.5.
Rate:5/5
Build ID               20150814002719
Gaia Revision          39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gaia Date              2015-08-13 18:25:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4e883591bb5dff021c108d3e30198a99547eed1e
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150813.235024
Firmware Date          Thu Aug 13 23:50:32 UTC 2015
Bootloader             s1

Comment 20

[Alissa（leave from Mozilla）]

Attachment: AriesKK_V2.5.png

Comment 21

[Julien Wajsberg [:julienw]]

I'd like to know how this was done on 2.0m branch before moving forward. I've been told it's been implemented like it is now on master and so I'd favor keeping it like it is.

Comment 22

[Dylan Oliver [:doliver]]

Kaze, can you confirm the orientation of this icon on 2.0m?

Comment 23

[Augustin Trancart [:autra]]

Dylan, Julien, I confirm that the send icon is MIRRORED on our 2.0m (I don't know about what is on mozilla's v2.0m). That's how we decided to implement it with Kaze and Ahmed. I'm also personally in favor of mirroring the send icons, because if we don't mirror it, we should not mirror the outgoing and incoming bubble either imho.

NI Ahmed to be sure.

Comment 24

[Ahmed Nefzaoui [:Nefzaoui]]

Indeed the send icon was mirrored in 2.0m RTL that was signed off for Orange back then.
I'm in favour of mirroring this icon (it's more of a right/wrong rather than IMO vs other opinions) (Stephany's comment might be related to the fact that in 2.2 back icons, apps order and many other things were not mirrored..)
But as of now we have a spec for 2.5 that makes sure such conflicts don't happen.

Comment 25

[Julien Wajsberg [:julienw]]

Thanks guys, let's close this bug, at last.