Closed Bug 1151306 Opened 9 years ago Closed 9 years ago

Map updates flicker on paint

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: jmjjeffery, Assigned: mstange)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(3 files)

testcase
846 bytes, text/html
Details
patch
980 bytes, patch
roc
: review+
Details | Diff | Splinter Review
test
2.40 KB, patch
roc
: review+
Details | Diff | Splinter Review 
Visit URL http://www.n2yo.com/?s=38348|25544 with latest Nightly/Tinderbox build note that the map flickers on update/paint.

20150402171927 6177eed6d23d OK
20150402174725 f4bc044e4d29 bad

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6177eed6d23d&tochange=f4bc044e4d29

Maybe caused by ?  https://bugzilla.mozilla.org/show_bug.cgi?id=1148855

Markus, possible that bug 1148855 caused this ?
( FYI, I saw another flickering, I filed Bug 1151319 )
Attached file testcase — 
Assignee: nobody → mstange
Status: NEW → ASSIGNED

    
    

    
  
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #0)
> Markus, possible that bug 1148855 caused this ?

Yes, most certainly.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
No test because I couldn't think of one that doesn't use animated position:absolute, and the detection whether left/top/right/bottom are animated still seems to depend on timing, even if there is a CSS animation that changes those properties. (And we don't seem to support will-change for them yet.)

        Attachment #8588446 -
        Flags: review?(roc)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        test
        — 
          — Splinter Review
      

    


  
Without bug 1151346, this test would have succeeded even without the patch in this bug, but with bug 1151346 it properly tests for it.

        Attachment #8588477 -
        Flags: review?(roc)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d8f65e1ada48
https://hg.mozilla.org/mozilla-central/rev/4450f65d2ba9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox40:
          affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

    
    

    
  
Testing with latest tinderbox build 20150406183107 cset: ab0490972e1e

I can verify that the flicker is gone.

thanks for the quick fix/turn-around.
Blocks: 1151889

    
  
No longer blocks: 1151889

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: