If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

make IAccessibleText and IAccessibleEditableText use proxies

RESOLVED FIXED in Firefox 40

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

unspecified
mozilla40
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8588536 [details] [diff] [review]
proxy most of IAccessibleText and IAccessibleEditableText
Attachment #8588536 - Flags: review?(dbolter)
Comment on attachment 8588536 [details] [diff] [review]
proxy most of IAccessibleText and IAccessibleEditableText

Review of attachment 8588536 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Just some formatting nits. I didn't grumble inline about how I wish we would always used braces even for single ifs. Onward!

::: accessible/ipc/DocAccessibleChild.h
@@ +179,5 @@
>  
>    virtual bool RecvDeleteText(const uint64_t& aID,
>                                const int32_t& aStartPos,
> +                              const int32_t& aEndPos, bool* aValid)
> +    MOZ_OVERRIDE;

The MOZ_OVERRIDE usually goes at the end of the previous line. (same for RecvPasteText)

::: accessible/ipc/ProxyAccessible.cpp
@@ +185,1 @@
>  ProxyAccessible::TextSubstring(int32_t aStartOffset, int32_t aEndOfset,

(We should fix the spelling of aEndOfset sometime but doesn't have to be here)

::: accessible/windows/ia2/ia2AccessibleEditableText.cpp
@@ +93,5 @@
>    A11Y_TRYBLOCK_BEGIN
>  
> +    if (ProxyAccessible* proxy = HyperTextProxyFor(this)) {
> +      return proxy->CutText(aStartOffset, aEndOffset) ? S_OK : E_INVALIDARG;
> +    }

nit: block is indented 2 spaces too far.

@@ +115,5 @@
>    A11Y_TRYBLOCK_BEGIN
>  
> +    if (ProxyAccessible* proxy = HyperTextProxyFor(this)) {
> +      return proxy->PasteText(aOffset) ? S_OK : E_INVALIDARG;
> +    }

nit: block is indented 2 spaces too far.
Attachment #8588536 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e6a2e727bdc4
https://hg.mozilla.org/mozilla-central/rev/e6a2e727bdc4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.