1151432 - Snackbar layout goes bad after switching tabs

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Screenshot 2015-04-06 09.27.02.png

STR:

1) Clean start the app
2) Go to news.ycombiantor.com
3) Login
4) The Snackbar appears, but do no dismiss it
5) Open a new tab, go to some random site
6) Go back to the tab where you had the snackbar open

See screenshot attached

Comment 1

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/458

I think the constraints fixes probably fixed this (I can't repro it), but I did notice these show on tabs other than the one they're relevant to. This fixes that bug (cause by bug 1159319 fix).

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8604931 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/458

Looks good. The snack bar animation looks a bit jank on the tab tray transitions but I feel like that's more part of the tab tray transition bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1163695. I think I'll make that bug a meta and file another bug under it

Comment 3

[Stephan Leroux [:sleroux]]

Filed animation bug under https://bugzilla.mozilla.org/show_bug.cgi?id=1164445