Closed
Bug 1151447
Opened 10 years ago
Closed 10 years ago
Don't use -mnop-fun-dllimport in mingw builds.
Categories
(NSS :: Build, defect)
Tracking
(firefox40 affected)
RESOLVED
FIXED
3.21
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | affected |
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
1020 bytes,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
This option was added in bug 337887 as a woraround for GCC/binutils limitations. It's not needed in recent versions and I don't think we care about such an old setup anymore. It causes problems like one already worked around in bug 451024, where thunks are needed for cross-dll calls, which may be unloaded too early. I recently got a report about such problem from TOR Project:
https://trac.torproject.org/projects/tor/ticket/10761
Attachment #8588582 -
Flags: review?(brian)
|
||
Updated•10 years ago
|
Attachment #8588582 -
Attachment is patch: true
Attachment #8588582 -
Flags: review?(brian) → review?(kaie)
|
||
Comment 1•10 years ago
|
||
This change was originally made in this commit:
https://hg.mozilla.org/projects/nss/rev/099480454292
I don't know if this change is reasonable. If you're working with MinGW and say this is required, I'll have to trust you. Given this isn't affecting our default Windows builds (which I believe use MS compilers), I'll give you r+. I wish there was a second person doing MinGW builds and who could ack your change.
|
|
||
Updated•10 years ago
|
Attachment #8588582 -
Flags: review?(kaie) → review+
|
|
||
Comment 2•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.20
|
|
||
Updated•10 years ago
|
Target Milestone: 3.20 → 3.21
You need to log in
before you can comment on or make changes to this bug.
Description
•