1151465 - Reading View needs an error interstitial (or maybe not)

Status: RESOLVED DUPLICATE of bug 1151464

(Firefox for iOS :: Reader View, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

When you add items to your reading list via the Share extension, we do not actually know yet if that content can be displayed by the Reader View. (Since we have not (can not) looked at the content at that point.

So when people later open that item in Firefox there is a change that we do not have readerized content available.

I can imagine two scenarios:

1) We display a message that says 'this content cannot be displayed in reading view' - with a 'Open original page' link. (Same kind of error/message as for bug 1151464)

2) We skip the warning message and just open the original page immediately.

Comment 1

[Robin Andersen [:tecgirl]]

we're going with the native spinner for this interaction.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

No spinner here. What we need is a simple page that says 'we cannot turn the requested page into reader view' or something similar.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/733

Work in progress. Still needs an image / spinner. And maybe quick look at strings / terminology.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8633595 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/733

Removing this PR since I attached it to the wrong bug.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Going to mark this as a dupe because this error message is actually part of bug 1151464