1151487 - Enable software vsync compositor on Fennec

Status: RESOLVED FIXED

(Core :: Graphics, defect, P2)

Description

[Mason Chang [Inactive] [:mchang]]

Enable the software vsync compositor on fennec

Comment 1

[Mason Chang [Inactive] [:mchang]]

Looks good on try I think - https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc28bfbc075e

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Enable software vsync compositor on fennec

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8589278 [details] [diff] [review]
Enable software vsync compositor on fennec

Review of attachment 8589278 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +4665,5 @@
>  pref("gfx.vsync.compositor", true);
>  pref("gfx.vsync.refreshdriver", true);
>  #endif
>  
> +#if defined(ANDROID)

use MOZ_WIDGET_ANDROID. ANDROID includes B2G which is not what you want here

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8589278 [details] [diff] [review]
Enable software vsync compositor on fennec

Review of attachment 8589278 [details] [diff] [review]:
-----------------------------------------------------------------

Actually.. probably better to just put it in mobile/android/app/mobile.js

Comment 5

[Mason Chang [Inactive] [:mchang]]

Attachment: Enable software vsync compositor on fennec

Moved to mobile/android/app/mobile.js

Looks like I don't need any ifdefs for android right?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8589385 [details] [diff] [review]
Enable software vsync compositor on fennec

Review of attachment 8589385 [details] [diff] [review]:
-----------------------------------------------------------------

Yup this looks good.

Comment 7

[Mason Chang [Inactive] [:mchang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56dd29d29147

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56dd29d29147